Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add goldmark's CJK extension support #10472

Closed
keichi opened this issue Nov 27, 2022 · 2 comments · Fixed by #11356
Closed

Add goldmark's CJK extension support #10472

keichi opened this issue Nov 27, 2022 · 2 comments · Fixed by #11356
Labels
Enhancement Outdated
Milestone
v0.118.0

Comments

@keichi
Copy link

keichi commented Nov 27, 2022

When blackfriday was the default markdown renderer, we could enable the joinLines extension (introduced in #3574) to use CJK-style line breaks.

This feature was removed when the renderer was changed to goldmark, but goldmark recently added a CJK extension that enables CJK-style line breaks. It would be very helpful for CJK users if this extension can be used from hugo.
@bep bep added this to the v0.109.0 milestone Jan 13, 2023
@bep bep mentioned this issue Jan 13, 2023
Open
@bep bep modified the milestones: v0.109.0, v0.111.0 Jan 26, 2023
@bep bep modified the milestones: v0.111.0, v0.112.0 Feb 15, 2023
@bep bep modified the milestones: v0.112.0, v0.113.0 Apr 15, 2023
@bep bep modified the milestones: v0.113.0, v0.115.0 Jun 13, 2023
@bep bep modified the milestones: v0.115.0, v0.116.0 Jun 30, 2023
@bep bep modified the milestones: v0.116.0, v0.117.0 Aug 1, 2023
henry0312 added a commit to henry0312/hugo that referenced this issue Aug 13, 2023
@henry0312
markup/goldmark: add support for CJK extension
147e5f9 
This commit fixes gohugoio#10472.
@henry0312 henry0312 mentioned this issue Aug 13, 2023
Merged
@henry0312
Copy link
Contributor

@bep Sorry to bother you, but could you please review #11356? Thank you.

@bep bep modified the milestones: v0.117.0, v0.118.0 Aug 30, 2023
bep pushed a commit that referenced this issue Aug 30, 2023
@henry0312
markup/goldmark: Add CJK extension
d7dcc76 
Fixes #10472
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Enhancement Outdated
Projects
None yet
Milestone
v0.118.0
Development

Successfully merging a pull request may close this issue.

markup/goldmark: add support for CJK extension henry0312/hugo
3 participants
@bep @henry0312 @keichi