Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeout for http.Client in resources.GetRemote #10478

Closed
dirtymew opened this issue Nov 29, 2022 · 2 comments
Closed

Increase timeout for http.Client in resources.GetRemote #10478

dirtymew opened this issue Nov 29, 2022 · 2 comments

Comments

@dirtymew
Copy link
Contributor

For long term responses while getting resources by resources.GetRemote
Will be useful to
increase value of timeout for http.Client (e.g. 1 minute)- now it setup to 10 seconds
or make it configurable
(discussion - https://discourse.gohugo.io/t/get-large-files-by-resources-getremote/41657)

https://github.com/gohugoio/hugo/blob/master/resources/resource_factories/create/create.go#L43-L52

@bep
Copy link
Member

bep commented Nov 29, 2022

I'm not sure to put that option, so I suggest we just start by making it 1 minute. PR welcome.

dirtymew added a commit to dirtymew/hugo that referenced this issue Nov 29, 2022
Increase timeout for http.Client in resources.GetRemote  from 10 second to 1 minute

Issue gohugoio#10478
@bep bep closed this as completed in a49e51f Dec 3, 2022
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants