Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in 0.113.0 for static files in /content in some multilingual setups #11223

Closed
bep opened this issue Jul 8, 2023 · 1 comment
Closed
Assignees
Milestone

Comments

@bep
Copy link
Member

bep commented Jul 8, 2023

E.g. for non-content files that's not part of a bundle.

In short, because of a typo (and missing test cases):

func (p *Paths) GetTargetLanguageBasePath() string {
	if p.Languages.IsMultihost() {
		// In a multihost configuration all assets will be published below the language code.
		return p.Lang()
	}
	return p.GetLanguagePrefix()
}

Became.

func (p *Paths) GetTargetLanguageBasePath() string {
	if len(p.Cfg.Languages()) > 1 {
		// In a multihost configuration all assets will be published below the language code.
		return p.Lang()
	}
	return p.GetLanguagePrefix()
}
@bep bep added the Bug label Jul 8, 2023
@bep bep self-assigned this Jul 8, 2023
@bep bep modified the milestones: v0.116.0, v0.115.2 Jul 8, 2023
bep added a commit to bep/hugo that referenced this issue Jul 8, 2023
bep added a commit to bep/hugo that referenced this issue Jul 8, 2023
@bep bep closed this as completed in 6019953 Jul 8, 2023
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant