Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate taxonomyTerm page kind #11256

Closed
jmooring opened this issue Jul 16, 2023 · 1 comment
Closed

Deprecate taxonomyTerm page kind #11256

jmooring opened this issue Jul 16, 2023 · 1 comment
Assignees
@bep
Labels
Enhancement Outdated
Milestone
v0.116.0

Comments

@jmooring
Copy link
Member

jmooring commented Jul 16, 2023 •
edited

The taxonomyTerm page kind was effectively aliased to the taxonomy page kind in v0.73.0. It's been three years; we should either:

  1. Start throwing a deprecation warning, or
  2. Throw an error (breaking change, but then #11257 is sort of a non-issue)

While the body's open, it would be helpful if we threw a warning or error when disableKinds contains invalid page kinds.

Somewhat related: #11257
@jmooring jmooring mentioned this issue Jul 16, 2023
Closed
@bep bep self-assigned this Jul 28, 2023
@bep bep added this to the v0.116.0 milestone Jul 28, 2023
bep added a commit to bep/hugo that referenced this issue Jul 28, 2023
@bep
Move all Kind constants to its own package
c91297b 
See gohugoio#11256
bep added a commit to bep/hugo that referenced this issue Jul 28, 2023
@bep
Warn about unknown kinds in disableKinds
837aa2a 
See gohugoio#11256
bep added a commit to bep/hugo that referenced this issue Jul 28, 2023
@bep
Deprecate taxonomyTerm
114d401 
In favour of 'taxonomy'

Closes gohugoio#11256
bep added a commit to bep/hugo that referenced this issue Jul 28, 2023
@bep
Deprecate taxonomyTerm
9f143ce 
In favour of 'taxonomy'

Closes gohugoio#11256
bep added a commit to bep/hugo that referenced this issue Jul 28, 2023
@bep
Move all Kind constants to its own package
e0d3716 
See gohugoio#11256
bep added a commit to bep/hugo that referenced this issue Jul 28, 2023
@bep
Warn about unknown kinds in disableKinds
ce9413c 
See gohugoio#11256
bep added a commit to bep/hugo that referenced this issue Jul 28, 2023
@bep
Deprecate taxonomyTerm
41c78b2 
In favour of 'taxonomy'

Closes gohugoio#11256
bep added a commit that referenced this issue Jul 28, 2023
@bep
Move all Kind constants to its own package
b3cb678 
See #11256
bep added a commit that referenced this issue Jul 28, 2023
@bep
Warn about unknown kinds in disableKinds
1c97095 
See #11256
@bep bep closed this as completed in bec9b80 Jul 28, 2023
khusika added a commit to khusika/FeelIt that referenced this issue Aug 2, 2023
@khusika
hugo: Rename taxonomy kinds from taxonomy to term, taxonomyTerm to ta…
d47bac7 
…xonomy

See gohugoio/hugo#11256

Signed-off-by: Khusika Dhamar Gusti <mail@khusika.dev>
khusika added a commit to khusika/khusika.github.io that referenced this issue Aug 2, 2023
@khusika
hugo: Rename taxonomyTerm
fd5ebde 
see gohugoio/hugo#11256

Signed-off-by: Khusika Dhamar Gusti <mail@khusika.dev>
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bep bep

Labels
Enhancement Outdated
Projects
None yet
Milestone
v0.116.0
Development

No branches or pull requests
2 participants
@jmooring @bep