Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hugo go syntax highlighter colors the schwa letters differently. 0.92.2 version outputs correctly #11311

Closed
quickwritereader opened this issue Jul 31, 2023 · 3 comments · Fixed by #11314
Assignees

Comments

@quickwritereader
Copy link

0.115.4

Hugo go syntax highlighter colors the schwa letters differently. 0.92.2 version outputs correctly

cc.md
image

@jmooring
Copy link
Member

jmooring commented Jul 31, 2023

Introduced in v0.107.0 when we bumped github.com/alecthomas/chroma from v2.3.0 to v2.4.0.

Chroma's go.mod file requires github.com/dlclark/regexp2 v1.4.0:
https://github.com/alecthomas/chroma/blob/e8acfc274c22a76fd38030d2977a2246cd4322b3/go.mod#L8

Hugo's go.mod file requires github.com/dlclark/regexp2 v1.10.0 (not sure how/why that happened):

hugo/go.mod

Line 108 in 5a7e0da

github.com/dlclark/regexp2 v1.10.0 // indirect

It looks like Chroma breaks with dlclark/regexp2 >= 1.5.0.

Created an upstream "heads-up" issue:
alecthomas/chroma#805

@jmooring jmooring self-assigned this Jul 31, 2023
@jmooring jmooring removed the Upstream label Jul 31, 2023
jmooring added a commit to jmooring/hugo that referenced this issue Jul 31, 2023
jmooring added a commit to jmooring/hugo that referenced this issue Jul 31, 2023
bep pushed a commit that referenced this issue Jul 31, 2023
@bep
Copy link
Member

bep commented Jul 31, 2023

(not sure how/why that happened)

My mistake. I guess I did

go get -u github.com/alecthomas/chroma/v2

When I should have

go get github.com/alecthomas/chroma/v2

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants