Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module disable should not disable other dependencies/modules required by other modules. #11376

Closed
razonyang opened this issue Aug 23, 2023 · 1 comment · Fixed by #11379
Closed

Module disable should not disable other dependencies/modules required by other modules. #11376

razonyang opened this issue Aug 23, 2023 · 1 comment · Fixed by #11379
Assignees
@bep
Labels
Bug Outdated
Milestone
v0.118.0

Comments

@razonyang
Copy link
Contributor

razonyang commented Aug 23, 2023 •
edited

Hi, I'm encountering an issue about disabling the modules, for example, there are two modules, foo and bar, both of them require the common module. Their configuration as follows.

[[module.imports]]
path = "modules/common"

And the site configuration as follows.

[[module.imports]]
path = "modules/foo"

[[module.imports]]
path = "modules/bar"

When I disable the foo module, then the common module will be disabled as well, which is unexpected and causes the bar module broken.

[[module.imports]]
path = "modules/foo"
disable = true

[[module.imports]]
path = "modules/bar"

What version of Hugo are you using (hugo version)?

$ hugo version
hugo v0.117.0-b2f0696cad918fb61420a6aff173eb36662b406e+extended linux/amd64 BuildDate=2023-08-07T12:49:48Z VendorInfo=snap:0.117.0

Does this issue reproduce with the latest release?

Yes
@bep bep removed the NeedsTriage label Aug 23, 2023
@bep bep added this to the v0.118.0 milestone Aug 23, 2023
@bep bep self-assigned this Aug 23, 2023
@bep bep mentioned this issue Aug 23, 2023
Merged
bep added a commit to bep/hugo that referenced this issue Aug 23, 2023
@bep
Fix it so disable a module does not disable transitive dependency req…
8c5aa0f 
…uired by others

The motivation behind the original implementation was probably to show disabled modules when running `hugo mod graph`.

Fixes gohugoio#11376
bep added a commit to bep/hugo that referenced this issue Aug 23, 2023
@bep
Fix it so disable a module does not disable transitive dependency req…
782fd18 
…uired by others

The motivation behind the original implementation was probably to show disabled modules when running `hugo mod graph`.

Fixes gohugoio#11376
bep added a commit that referenced this issue Aug 23, 2023
@bep
Fix it so disable a module does not disable transitive dependency req…
dcf425c 
…uired by others

The motivation behind the original implementation was probably to show disabled modules when running `hugo mod graph`.

Fixes #11376
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bep bep

Labels
Bug Outdated
Projects
None yet
Milestone
v0.118.0
Development

Successfully merging a pull request may close this issue.

Fix it so disable a module does not disable transitive dependency required by others bep/hugo
2 participants
@bep @razonyang