Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hugo >0.123.5 failing to render most of website menu #12218

Closed
danburd opened this issue Mar 8, 2024 · 5 comments
Closed

Hugo >0.123.5 failing to render most of website menu #12218

danburd opened this issue Mar 8, 2024 · 5 comments

Comments

@danburd
Copy link

danburd commented Mar 8, 2024

What version of Hugo are you using (hugo version)?

$ hugo version
hugo v0.123.8-5fed9c591b694f314e5939548e11cc3dcb79a79c+extended linux/amd64 BuildDate=2024-03-07T13:14:42Z VendorInfo=gohugoio

Does this issue reproduce with the latest release?

Yes


Hugo 0.123.6, 0.123.7, and 0.123.8 is failing to render most of the website menu in the Book theme where 0.123.5 is doing so without issues. Specifically, it's unable to render the pages which exist in a hierarchy of sections - links to pages that are in the menu's root render successfully. I believe that the operative code to render the hierarchical menu is here, between lines 10 and 25. Sorry that I'm not more knowledgeable about which functions in particular are not working.

I've filed an issue with the theme, but I suspect the issue is with Hugo itself as I don't believe that breaking changes are purposefully introduced in bugfix releases.

@jmooring
Copy link
Member

jmooring commented Mar 8, 2024

@danburd I am unable to reproduce this as described.

Using Hugo v0.123.8, here's what I did:

git clone --recurse-submodules https://github.com/alex-shpak/hugo-book
cd hugo-book/exampleSite/
hugo server --themesDir ../..

Here's what I got:

image

Please provide a failing example.

@danburd
Copy link
Author

danburd commented Mar 8, 2024

Update: the issue is only with headless branch bundles not showing up on the menu. (All of my page bundles were headless, which is why the issue seemed more broad at the time.) That's why the exampleSite worked and mine did not. I don't know if this is an issue with the theme or an issue with Hugo.

@jmooring
Copy link
Member

jmooring commented Mar 8, 2024

I am not comfortable troubleshooting this without access to your project repository. If you are making your bundles "headless" by adding headless = true to front matter, use build options instead. Again, without access to your site I am just guessing, but this sounds like we fixed a bug rather than introduced a new one.

@danburd
Copy link
Author

danburd commented Mar 8, 2024

I suppose the correct way to do this is to replace headless: true with:

build:
  render: never

Thanks. Closing.

@danburd danburd closed this as completed Mar 8, 2024
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants