Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

commands: Add --lineNumbersTableStyle flag to gen chromastyles #12393

Closed
jmooring opened this issue Apr 18, 2024 · 0 comments · Fixed by #12394
Closed

commands: Add --lineNumbersTableStyle flag to gen chromastyles #12393

jmooring opened this issue Apr 18, 2024 · 0 comments · Fixed by #12394
Labels
Enhancement
Milestone
v0.125.2

Comments

@jmooring
Copy link
Member

jmooring commented Apr 18, 2024 •
edited

The existing --linesStyle flag sets the foreground and background colors for inline line numbers. This flag has no effect when using lineNumbersInTable=true, and lineNumbersInTable=true is the default when lineNos=true. So, out of the box when enabling line numbers, you cannot set the line number foreground and background colors without manually editing the stylesheet.

Using lineNumbersInTable=true is desirable to work around this Firefox bug that is unlikely to ever be fixed:
https://bugzilla.mozilla.org/show_bug.cgi?id=1273836

At the same time, rename the existing --linesStyle flag to --lineNumbersInlineStyle for symmetry.
@jmooring jmooring changed the title commands: Add --lineNumbersTable flat to gen chromastyles commands: Add --lineNumbersTable flag to gen chromastyles Apr 18, 2024
@jmooring jmooring mentioned this issue Apr 18, 2024
Merged
@jmooring jmooring changed the title commands: Add --lineNumbersTable flag to gen chromastyles commands: Add --lineNumbersTableStyle flag to gen chromastyles Apr 18, 2024
jmooring added a commit to jmooring/hugo that referenced this issue Apr 18, 2024
@jmooring
commands: Add gen chromastyles --lineNumbersTableStyle flag
5813c41 
For symmetry, also rename --linesStyle to --lineNumbersInlineStyle.

Closes gohugoio#12393
@jmooring jmooring mentioned this issue Apr 18, 2024
Merged
@bep bep added this to the v0.125.2 milestone Apr 20, 2024
bep pushed a commit that referenced this issue Apr 20, 2024
@jmooring @bep
commands: Add gen chromastyles --lineNumbersTableStyle flag
da6112f 
For symmetry, also rename --linesStyle to --lineNumbersInlineStyle.

Closes #12393
@gcushen gcushen mentioned this issue Apr 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
v0.125.2
Development

Successfully merging a pull request may close this issue.

commands: Add gen chromastyles --lineNumbersTableStyle flag jmooring/hugo
2 participants
@jmooring @bep