Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quickstart Guide broken at Step 8 #2331

Closed
MarkDBlackwell opened this issue Aug 5, 2016 · 1 comment
Closed

Quickstart Guide broken at Step 8 #2331

MarkDBlackwell opened this issue Aug 5, 2016 · 1 comment
Labels

Comments

@MarkDBlackwell
Copy link
Contributor

MarkDBlackwell commented Aug 5, 2016

The Quickstart Guide seems broken at Step 8. Customize robust theme. The Guide's recommended actions don't change the appearance of the browser, fully as the Guide claims.

The Guide is correct, through the point of code evolution where the browser tab appears as here (including the post title and text).

In particular (in the next step), the Guide says, "We have removed details of the book so that only image is shown" and says the results should be as here. However, in actuality, the post's title and text remain, just as before. (Other test alterations I tried to the new, overriding file bookshelf/layouts/_default/li.html did appear in the browser.)

To a Hugo novice, this seems mysterious.

Of course, this brokenness might lessen Hugo's uptake of new users. (It frustrates them at a critical, early moment: when they're following the Quickstart Guide.)

I speculate this breakage may be from:

  1. Changes in the Hugo executable's functionality; or
  2. Changes in the theme, hugo_theme_robust.

This kind of problem IMO would seem to diminish if somehow the spf13/hugo repository itself were to version control some Hugo theme for the Quickstart Guide to use (just as it version controls the guide itself). This isn't true already (supposedly).

Seemingly, another solution would lie in changing the Quickstart guide so that it specifies checking out the above theme from a particular commit known to work (rather than from its latest commit—assuming the theme is the problem.) For example:

    $ git clone https://github.com/dim0627/hugo_theme_robust.git
    $ cd hugo_theme_robust
    $ git checkout b8ce466

That approach might be explainable to new users.

As to my Hugo version, I built Hugo from pull request commit 689e7e19e56ae5bd0e50de1fdddaffaad4299013 forked at d7f364c (but IMO that seems unlikely to have caused the problem).

$ hugo version
Hugo Static Site Generator v0.17-DEV BuildDate: 2016-08-03T14:45:33-04:00

OS: Windows XP, Git for Windows

digitalcraftsman pushed a commit that referenced this issue Sep 3, 2016
tychoish pushed a commit to tychoish/hugo that referenced this issue Aug 13, 2017
@github-actions
Copy link

github-actions bot commented Apr 3, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant