Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an unified .Site.Config with a services section #4751

Closed
bep opened this issue May 22, 2018 · 1 comment
Closed

Add an unified .Site.Config with a services section #4751

bep opened this issue May 22, 2018 · 1 comment
Assignees
Milestone

Comments

@bep
Copy link
Member

bep commented May 22, 2018

With the recent privacy config addition, we can do:

.Site.PrivacyConfig.Instagram

Working on making "privacy friendly" editions of some of the shortcodes, we need to add some additional service-specific config. This is currently not possible without too much ceremony. It needs to be available from shortcodes and we don't want to add another top level .Site field.

Back when Hugo was a youngster, it probably made sense to put DisqusShortname on the top level site config, but now that looks sub-optimal.

We can fix that while keeping the old sites working as before.

It also makes sense to keep the privacy config as one copy-and-paste-friendly entity. So I suggest that we make it so:

.Site.Config.Privacy.Instagram
.Site.Config.Services.Instagram

Would give two config objects that both relate to Instagram.

Also, we should make it so

.Site.Config.Services.Disqus.Shortname

Points to the same value as .Site.DisqusShortname (keeping the old, but eventually remove it from the docs).

Also consider:

googleanalytics

There are other candidates, but those will have to wait.

@bep bep added this to the v0.41 milestone May 22, 2018
@bep bep self-assigned this May 22, 2018
bep added a commit to bep/hugo that referenced this issue May 22, 2018
bep added a commit to bep/hugo that referenced this issue May 22, 2018
bep added a commit that referenced this issue May 22, 2018
@bep bep closed this as completed in 4ddcf52 May 22, 2018
bep added a commit that referenced this issue May 23, 2018
bep added a commit that referenced this issue May 25, 2018
bep added a commit that referenced this issue May 25, 2018
We need to revisit and complete that.

See #4751
bep added a commit that referenced this issue May 25, 2018
@github-actions
Copy link

github-actions bot commented Mar 4, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant