Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disableKind for Page should still add regular pages to the page collections #6087

Closed
bep opened this issue Jul 11, 2019 · 3 comments · Fixed by #6732
Closed

disableKind for Page should still add regular pages to the page collections #6087

bep opened this issue Jul 11, 2019 · 3 comments · Fixed by #6732
Assignees
@bep
Labels
Bug Outdated
Milestone
v0.65

Comments

@bep
Copy link
Member

bep commented Jul 11, 2019

I had a head-scratcher with this when I tested a theme I built several years ago:

  • It's a single home page theme that just lists pages.
  • I got an error about a missing single template, so I disabled page kind.
  • And then the page listing vanished.

This does not make sense. We probably need to revisit the whole disable thing, but for now we adjust the behaviour for regular pages:

  • If disabled, skip render, but do add them to the page collection so they can be listed if needed.
@bep bep added the Bug label Jul 11, 2019
@bep bep added this to the v0.56 milestone Jul 11, 2019
@bep bep self-assigned this Jul 11, 2019
@guylyons
Copy link

Is there a repo for the theme?

@bep
Copy link
Member Author

bep commented Jul 15, 2019

It's the docuapi theme under my account, but I suspect this use case is common enough: The current workaround is to create an empty single.html layout, but that sounds wasteful. I think we need to rethink this whole "disabled semantic" thing, though.

@bep bep modified the milestones: v0.56, v0.57, v0.58 Jul 26, 2019
@bep bep modified the milestones: v0.58, v0.59 Aug 13, 2019
@bep bep modified the milestones: v0.59, v0.60 Sep 6, 2019
@bep bep modified the milestones: v0.60, v0.61 Oct 21, 2019
@bep bep modified the milestones: v0.61, v0.62, v0.63 Nov 25, 2019
@bep bep modified the milestones: v0.63, v0.64 Dec 11, 2019
@bep bep changed the title disableKind for Page should still add regular pages to the page collectionsya disableKind for Page should still add regular pages to the page collections Jan 9, 2020
@bep bep modified the milestones: v0.64, v0.63 Jan 9, 2020
bep added a commit to bep/hugo that referenced this issue Jan 9, 2020
@bep
Introduce a map for all content
fa54d4a 
This commit introduces a new data structure to store pages and their resources.

This data structure is backed by radix trees.

This simplies tree operations and paves the way for gohugoio#6310.

Fixes gohugoio#6312
Fixes gohugoio#6087
@bep bep mentioned this issue Jan 9, 2020
Merged
bep added a commit to bep/hugo that referenced this issue Jan 9, 2020
@bep
Introduce a map for all content
1f252dc 
This commit introduces a new data structure to store pages and their resources.

This data structure is backed by radix trees.

This simplies tree operations and paves the way for gohugoio#6310.

Fixes gohugoio#6312
Fixes gohugoio#6087
bep added a commit to bep/hugo that referenced this issue Jan 11, 2020
@bep
Introduce a map for all content
af96ea1 
This commit introduces a new data structure to store pages and their resources.

This data structure is backed by radix trees.

This simplies tree operations and paves the way for gohugoio#6310.

Fixes gohugoio#6312
Fixes gohugoio#6087
Fixes gohugoio#6738
Fixes gohugoio#6412
bep added a commit to bep/hugo that referenced this issue Jan 13, 2020
@bep
Introduce a map for all content
5ee6e44 
This commit introduces a new data structure to store pages and their resources.

This data structure is backed by radix trees.

This simplies tree operations and paves the way for gohugoio#6310.

Fixes gohugoio#6312
Fixes gohugoio#6087
Fixes gohugoio#6738
Fixes gohugoio#6412
Fixes gohugoio#6743
bep added a commit to bep/hugo that referenced this issue Jan 13, 2020
@bep
Introduce a map for all content
444778c 
This commit introduces a new data structure to store pages and their resources.

This data structure is backed by radix trees.

This simplies tree operations and paves the way for gohugoio#6310.

Fixes gohugoio#6312
Fixes gohugoio#6087
Fixes gohugoio#6738
Fixes gohugoio#6412
Fixes gohugoio#6743
@bep bep added this to the v0.65 milestone Jan 30, 2020
bep added a commit to bep/hugo that referenced this issue Feb 4, 2020
@bep
Introduce a map for all content
b64eb63 
This commit introduces a new data structure to store pages and their resources.

This data structure is backed by radix trees.

This simplies tree operations and paves the way for gohugoio#6310.

Fixes gohugoio#6312
Fixes gohugoio#6087
Fixes gohugoio#6738
Fixes gohugoio#6412
Fixes gohugoio#6743
bep added a commit to bep/hugo that referenced this issue Feb 4, 2020
@bep
Introduce a map for all content
3c51f35 
This commit introduces a new data structure to store pages and their resources.

This data structure is backed by radix trees.

This simplies tree operations and paves the way for gohugoio#6310.

Fixes gohugoio#6312
Fixes gohugoio#6087
Fixes gohugoio#6738
Fixes gohugoio#6412
Fixes gohugoio#6743
bep added a commit to bep/hugo that referenced this issue Feb 10, 2020
@bep
Introduce a map for all content
845d682 
This commit introduces a new data structure to store pages and their resources.

This data structure is backed by radix trees.

This simplies tree operations and paves the way for gohugoio#6310.

Fixes gohugoio#6312
Fixes gohugoio#6087
Fixes gohugoio#6738
Fixes gohugoio#6412
Fixes gohugoio#6743
bep added a commit to bep/hugo that referenced this issue Feb 10, 2020
@bep
Introduce a map for all content
907eed6 
This commit introduces a new data structure to store pages and their resources.

This data structure is backed by radix trees.

This simplies tree operations and paves the way for gohugoio#6310.

Fixes gohugoio#6312
Fixes gohugoio#6087
Fixes gohugoio#6738
Fixes gohugoio#6412
Fixes gohugoio#6743
bep added a commit to bep/hugo that referenced this issue Feb 14, 2020
@bep
Introduce a map for all content
6558f9c 
This commit introduces a new data structure to store pages and their resources.

This data structure is backed by radix trees.

This simplies tree operations and paves the way for gohugoio#6310.

Fixes gohugoio#6312
Fixes gohugoio#6087
Fixes gohugoio#6738
Fixes gohugoio#6412
Fixes gohugoio#6743
Fixes gohugoio#6875
bep added a commit to bep/hugo that referenced this issue Feb 14, 2020
@bep
Introduce a map for all content
9da5840 
This commit introduces a new data structure to store pages and their resources.

This data structure is backed by radix trees.

This simplies tree operations and paves the way for gohugoio#6310.

Fixes gohugoio#6312
Fixes gohugoio#6087
Fixes gohugoio#6738
Fixes gohugoio#6412
Fixes gohugoio#6743
Fixes gohugoio#6875
bep added a commit to bep/hugo that referenced this issue Feb 14, 2020
@bep
Introduce a tree map for all content
4abad5d 
This commit introduces a new data structure to store pages and their resources.

This data structure is backed by radix trees.

This simplies tree operations and paves the way for gohugoio#6310.

Fixes gohugoio#6312
Fixes gohugoio#6087
Fixes gohugoio#6738
Fixes gohugoio#6412
Fixes gohugoio#6743
Fixes gohugoio#6875
bep added a commit to bep/hugo that referenced this issue Feb 14, 2020
@bep
Introduce a tree map for all content
93767cd 
This commit introduces a new data structure to store pages and their resources.

This data structure is backed by radix trees.

This simplies tree operations and paves the way for gohugoio#6310.

Fixes gohugoio#6312
Fixes gohugoio#6087
Fixes gohugoio#6738
Fixes gohugoio#6412
Fixes gohugoio#6743
Fixes gohugoio#6875
bep added a commit to bep/hugo that referenced this issue Feb 14, 2020
@bep
Introduce a tree map for all content
d3e5a29 
This commit introduces a new data structure to store pages and their resources.

This data structure is backed by radix trees.

This simplies tree operations, makes all pages a bundle,  and paves the way for gohugoio#6310.

Fixes gohugoio#6312
Fixes gohugoio#6087
Fixes gohugoio#6738
Fixes gohugoio#6412
Fixes gohugoio#6743
Fixes gohugoio#6875
bep added a commit to bep/hugo that referenced this issue Feb 14, 2020
@bep
Introduce a tree map for all content
a502e31 
This commit introduces a new data structure to store pages and their resources.

This data structure is backed by radix trees.

This simplies tree operations, makes all pages a bundle,  and paves the way for gohugoio#6310.

Fixes gohugoio#6312
Fixes gohugoio#6087
Fixes gohugoio#6738
Fixes gohugoio#6412
Fixes gohugoio#6743
Fixes gohugoio#6875
bep added a commit to bep/hugo that referenced this issue Feb 14, 2020
@bep
Introduce a tree map for all content
9e8df84 
This commit introduces a new data structure to store pages and their resources.

This data structure is backed by radix trees.

This simplies tree operations, makes all pages a bundle,  and paves the way for gohugoio#6310.

Fixes gohugoio#6312
Fixes gohugoio#6087
Fixes gohugoio#6738
Fixes gohugoio#6412
Fixes gohugoio#6743
Fixes gohugoio#6875
bep added a commit to bep/hugo that referenced this issue Feb 14, 2020
@bep
Introduce a tree map for all content
e1f9fdb 
This commit introduces a new data structure to store pages and their resources.

This data structure is backed by radix trees.

This simplies tree operations, makes all pages a bundle,  and paves the way for gohugoio#6310.

Fixes gohugoio#6312
Fixes gohugoio#6087
Fixes gohugoio#6738
Fixes gohugoio#6412
Fixes gohugoio#6743
Fixes gohugoio#6875
bep added a commit to bep/hugo that referenced this issue Feb 15, 2020
@bep
Introduce a tree map for all content
b4a59e8 
This commit introduces a new data structure to store pages and their resources.

This data structure is backed by radix trees.

This simplies tree operations, makes all pages a bundle,  and paves the way for gohugoio#6310.

Fixes gohugoio#6312
Fixes gohugoio#6087
Fixes gohugoio#6738
Fixes gohugoio#6412
Fixes gohugoio#6743
Fixes gohugoio#6875
Fixes gohugoio#6034
@bep bep mentioned this issue Feb 15, 2020
Closed
bep added a commit to bep/hugo that referenced this issue Feb 16, 2020
@bep
Introduce a tree map for all content
1e0d39c 
This commit introduces a new data structure to store pages and their resources.

This data structure is backed by radix trees.

This simplies tree operations, makes all pages a bundle,  and paves the way for gohugoio#6310.

Fixes gohugoio#6312
Fixes gohugoio#6087
Fixes gohugoio#6738
Fixes gohugoio#6412
Fixes gohugoio#6743
Fixes gohugoio#6875
Fixes gohugoio#6034
Fixes gohugoio#6902
bep added a commit to bep/hugo that referenced this issue Feb 16, 2020
@bep
Introduce a tree map for all content
37585cb 
This commit introduces a new data structure to store pages and their resources.

This data structure is backed by radix trees.

This simplies tree operations, makes all pages a bundle,  and paves the way for gohugoio#6310.

Fixes gohugoio#6312
Fixes gohugoio#6087
Fixes gohugoio#6738
Fixes gohugoio#6412
Fixes gohugoio#6743
Fixes gohugoio#6875
Fixes gohugoio#6034
Fixes gohugoio#6902
bep added a commit to bep/hugo that referenced this issue Feb 16, 2020
@bep
Introduce a tree map for all content
1399b59 
This commit introduces a new data structure to store pages and their resources.

This data structure is backed by radix trees.

This simplies tree operations, makes all pages a bundle,  and paves the way for gohugoio#6310.

Fixes gohugoio#6312
Fixes gohugoio#6087
Fixes gohugoio#6738
Fixes gohugoio#6412
Fixes gohugoio#6743
Fixes gohugoio#6875
Fixes gohugoio#6034
Fixes gohugoio#6902
bep added a commit to bep/hugo that referenced this issue Feb 17, 2020
@bep
Introduce a tree map for all content
5fb8145 
This commit introduces a new data structure to store pages and their resources.

This data structure is backed by radix trees.

This simplies tree operations, makes all pages a bundle,  and paves the way for gohugoio#6310.

Fixes gohugoio#6312
Fixes gohugoio#6087
Fixes gohugoio#6738
Fixes gohugoio#6412
Fixes gohugoio#6743
Fixes gohugoio#6875
Fixes gohugoio#6034
Fixes gohugoio#6902
Fixes gohugoio#6173
Fixes gohugoio#6590
bep added a commit to bep/hugo that referenced this issue Feb 17, 2020
@bep
Introduce a tree map for all content
d67d14c 
This commit introduces a new data structure to store pages and their resources.

This data structure is backed by radix trees.

This simplies tree operations, makes all pages a bundle,  and paves the way for gohugoio#6310.

Fixes gohugoio#6312
Fixes gohugoio#6087
Fixes gohugoio#6738
Fixes gohugoio#6412
Fixes gohugoio#6743
Fixes gohugoio#6875
Fixes gohugoio#6034
Fixes gohugoio#6902
Fixes gohugoio#6173
Fixes gohugoio#6590
bep added a commit to bep/hugo that referenced this issue Feb 17, 2020
@bep
Introduce a tree map for all content
bacfc8e 
This commit introduces a new data structure to store pages and their resources.

This data structure is backed by radix trees.

This simplies tree operations, makes all pages a bundle,  and paves the way for gohugoio#6310.

Fixes gohugoio#6312
Fixes gohugoio#6087
Fixes gohugoio#6738
Fixes gohugoio#6412
Fixes gohugoio#6743
Fixes gohugoio#6875
Fixes gohugoio#6034
Fixes gohugoio#6902
Fixes gohugoio#6173
Fixes gohugoio#6590
bep added a commit to bep/hugo that referenced this issue Feb 18, 2020
@bep
Introduce a tree map for all content
ae6e476 
This commit introduces a new data structure to store pages and their resources.

This data structure is backed by radix trees.

This simplies tree operations, makes all pages a bundle,  and paves the way for gohugoio#6310.

Fixes gohugoio#6312
Fixes gohugoio#6087
Fixes gohugoio#6738
Fixes gohugoio#6412
Fixes gohugoio#6743
Fixes gohugoio#6875
Fixes gohugoio#6034
Fixes gohugoio#6902
Fixes gohugoio#6173
Fixes gohugoio#6590
bep added a commit to bep/hugo that referenced this issue Feb 18, 2020
@bep
Introduce a tree map for all content
80074f8 
This commit introduces a new data structure to store pages and their resources.

This data structure is backed by radix trees.

This simplies tree operations, makes all pages a bundle,  and paves the way for gohugoio#6310.

It also solves a set of annoying issues (see list below).

Not a motivation behind this, but this commit also makes Hugo in general a little bit faster and more memory effective (see benchmarks). Especially for partial rebuilds on content edits, but also when taxonomies is in use.

```
name                                   old time/op    new time/op    delta
SiteNew/Bundle_with_image/Edit-16        1.32ms ± 8%    1.00ms ± 9%  -24.42%  (p=0.029 n=4+4)
SiteNew/Bundle_with_JSON_file/Edit-16    1.28ms ± 0%    0.94ms ± 0%  -26.26%  (p=0.029 n=4+4)
SiteNew/Tags_and_categories/Edit-16      33.9ms ± 2%    21.8ms ± 1%  -35.67%  (p=0.029 n=4+4)
SiteNew/Canonify_URLs/Edit-16            40.6ms ± 1%    37.7ms ± 3%   -7.20%  (p=0.029 n=4+4)
SiteNew/Deep_content_tree/Edit-16        56.7ms ± 0%    51.7ms ± 1%   -8.82%  (p=0.029 n=4+4)
SiteNew/Many_HTML_templates/Edit-16      19.9ms ± 2%    18.3ms ± 3%   -7.64%  (p=0.029 n=4+4)
SiteNew/Page_collections/Edit-16         37.9ms ± 4%    34.0ms ± 2%  -10.28%  (p=0.029 n=4+4)
SiteNew/Bundle_with_image-16             10.7ms ± 0%    10.6ms ± 0%   -1.15%  (p=0.029 n=4+4)
SiteNew/Bundle_with_JSON_file-16         10.8ms ± 0%    10.7ms ± 0%   -1.05%  (p=0.029 n=4+4)
SiteNew/Tags_and_categories-16           43.2ms ± 1%    39.6ms ± 1%   -8.35%  (p=0.029 n=4+4)
SiteNew/Canonify_URLs-16                 47.6ms ± 1%    47.3ms ± 0%     ~     (p=0.057 n=4+4)
SiteNew/Deep_content_tree-16             73.0ms ± 1%    74.2ms ± 1%     ~     (p=0.114 n=4+4)
SiteNew/Many_HTML_templates-16           37.9ms ± 0%    38.1ms ± 1%     ~     (p=0.114 n=4+4)
SiteNew/Page_collections-16              53.6ms ± 1%    54.7ms ± 1%   +2.09%  (p=0.029 n=4+4)

name                                   old alloc/op   new alloc/op   delta
SiteNew/Bundle_with_image/Edit-16         486kB ± 0%     430kB ± 0%  -11.47%  (p=0.029 n=4+4)
SiteNew/Bundle_with_JSON_file/Edit-16     265kB ± 0%     209kB ± 0%  -21.06%  (p=0.029 n=4+4)
SiteNew/Tags_and_categories/Edit-16      13.6MB ± 0%     8.8MB ± 0%  -34.93%  (p=0.029 n=4+4)
SiteNew/Canonify_URLs/Edit-16            66.5MB ± 0%    63.9MB ± 0%   -3.95%  (p=0.029 n=4+4)
SiteNew/Deep_content_tree/Edit-16        28.8MB ± 0%    25.8MB ± 0%  -10.55%  (p=0.029 n=4+4)
SiteNew/Many_HTML_templates/Edit-16      6.16MB ± 0%    5.56MB ± 0%   -9.86%  (p=0.029 n=4+4)
SiteNew/Page_collections/Edit-16         16.9MB ± 0%    16.0MB ± 0%   -5.19%  (p=0.029 n=4+4)
SiteNew/Bundle_with_image-16             2.28MB ± 0%    2.29MB ± 0%   +0.35%  (p=0.029 n=4+4)
SiteNew/Bundle_with_JSON_file-16         2.07MB ± 0%    2.07MB ± 0%     ~     (p=0.114 n=4+4)
SiteNew/Tags_and_categories-16           14.3MB ± 0%    13.2MB ± 0%   -7.30%  (p=0.029 n=4+4)
SiteNew/Canonify_URLs-16                 69.1MB ± 0%    69.0MB ± 0%     ~     (p=0.343 n=4+4)
SiteNew/Deep_content_tree-16             31.3MB ± 0%    31.8MB ± 0%   +1.49%  (p=0.029 n=4+4)
SiteNew/Many_HTML_templates-16           10.8MB ± 0%    10.9MB ± 0%   +1.11%  (p=0.029 n=4+4)
SiteNew/Page_collections-16              21.4MB ± 0%    21.6MB ± 0%   +1.15%  (p=0.029 n=4+4)

name                                   old allocs/op  new allocs/op  delta
SiteNew/Bundle_with_image/Edit-16         4.74k ± 0%     3.86k ± 0%  -18.57%  (p=0.029 n=4+4)
SiteNew/Bundle_with_JSON_file/Edit-16     4.73k ± 0%     3.85k ± 0%  -18.58%  (p=0.029 n=4+4)
SiteNew/Tags_and_categories/Edit-16        301k ± 0%      198k ± 0%  -34.14%  (p=0.029 n=4+4)
SiteNew/Canonify_URLs/Edit-16              389k ± 0%      373k ± 0%   -4.07%  (p=0.029 n=4+4)
SiteNew/Deep_content_tree/Edit-16          338k ± 0%      262k ± 0%  -22.63%  (p=0.029 n=4+4)
SiteNew/Many_HTML_templates/Edit-16        102k ± 0%       88k ± 0%  -13.81%  (p=0.029 n=4+4)
SiteNew/Page_collections/Edit-16           176k ± 0%      152k ± 0%  -13.32%  (p=0.029 n=4+4)
SiteNew/Bundle_with_image-16              26.8k ± 0%     26.8k ± 0%   +0.05%  (p=0.029 n=4+4)
SiteNew/Bundle_with_JSON_file-16          26.8k ± 0%     26.8k ± 0%   +0.05%  (p=0.029 n=4+4)
SiteNew/Tags_and_categories-16             273k ± 0%      245k ± 0%  -10.36%  (p=0.029 n=4+4)
SiteNew/Canonify_URLs-16                   396k ± 0%      398k ± 0%   +0.39%  (p=0.029 n=4+4)
SiteNew/Deep_content_tree-16               317k ± 0%      325k ± 0%   +2.53%  (p=0.029 n=4+4)
SiteNew/Many_HTML_templates-16             146k ± 0%      147k ± 0%   +0.98%  (p=0.029 n=4+4)
SiteNew/Page_collections-16                210k ± 0%      215k ± 0%   +2.44%  (p=0.029 n=4+4)
```

Fixes gohugoio#6312
Fixes gohugoio#6087
Fixes gohugoio#6738
Fixes gohugoio#6412
Fixes gohugoio#6743
Fixes gohugoio#6875
Fixes gohugoio#6034
Fixes gohugoio#6902
Fixes gohugoio#6173
Fixes gohugoio#6590
@bep bep mentioned this issue Feb 18, 2020
Closed
@bep bep closed this as completed in #6732 Feb 18, 2020
@bep bep closed this as completed in eada236 Feb 18, 2020
@github-actions
Copy link

github-actions bot commented Feb 7, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bep bep

Labels
Bug Outdated
Projects
None yet
Milestone
v0.65
2 participants
@bep @guylyons