Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check 404 etc. IsAncestor vs the others #6931

Closed
bep opened this issue Feb 21, 2020 · 5 comments · Fixed by #6933
Closed

Check 404 etc. IsAncestor vs the others #6931

bep opened this issue Feb 21, 2020 · 5 comments · Fixed by #6933
Labels
Outdated
Milestone
0.65.3

Comments

@bep
Copy link
Member

bep commented Feb 21, 2020

See https://discourse.gohugo.io/t/runtime-error-calling-functions-on-section/23581
@onedrawingperday onedrawingperday mentioned this issue Feb 21, 2020
Closed
@onedrawingperday
Copy link
Contributor

There are 3 themes in the themes repo that broke due to this bug.

See: gohugoio/hugoThemes#810

@bep bep added this to the 0.65.3 milestone Feb 21, 2020
@bep
Copy link
Member Author

bep commented Feb 21, 2020

It would probably be worth the effort to somehow get the themes build for master as a CI build, somehow. I will think about it.

@tshort tshort mentioned this issue Feb 21, 2020
Closed
@tshort
Copy link

tshort commented Feb 21, 2020

Docsy has an IsDescendant issue with 0.65.x, so it might be the same as this. I don't know why it didn't get caught in gohugoio/hugoThemes#810.

google/docsy#210

@onedrawingperday
Copy link
Contributor

onedrawingperday commented Feb 21, 2020 •
edited

I don't know why it didn't get caught in gohugoio/hugoThemes#810.

See the rather long discussion at gohugoio/hugoThemes#650 for the answer.

@zzossig zzossig mentioned this issue Feb 22, 2020
Closed
bep added a commit to bep/hugo that referenced this issue Feb 22, 2020
@bep
Fix crashes for 404 in IsAncestor etc.
2392cf1 
Fixes gohugoio#6931
@bep bep mentioned this issue Feb 22, 2020
Merged
@bep bep closed this as completed in #6933 Feb 22, 2020
bep added a commit that referenced this issue Feb 22, 2020
@bep
Fix crashes for 404 in IsAncestor etc.
a524124 
Fixes #6931
@fmotrifork fmotrifork mentioned this issue Feb 24, 2020
Merged
@fmotrifork fmotrifork mentioned this issue Mar 4, 2020
Merged
@github-actions
Copy link

github-actions bot commented Feb 7, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Outdated
Projects
None yet
Milestone
0.65.3
Development

Successfully merging a pull request may close this issue.

Fix crashes for 404 in IsAncestor etc. bep/hugo
3 participants
@bep @tshort @onedrawingperday