Skip to content

/ hugo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transparency problem when converting 32-bit images to WebP #8729

Closed
jmooring opened this issue Jul 6, 2021 · 2 comments
Closed

Transparency problem when converting 32-bit images to WebP #8729

jmooring opened this issue Jul 6, 2021 · 2 comments
Labels
Bug
Milestone
v0.86

Comments

@jmooring
Copy link
Contributor

@jmooring jmooring commented Jul 6, 2021

Example:

image

Minimal reproducible example to follow...
@jmooring
Copy link
Contributor Author

@jmooring jmooring commented Jul 6, 2021

Minimal reproducible example:

git clone --single-branch -b hugo-github-issue-8729 https://github.com/jmooring/hugo-testing hugo-github-issue-8729
cd hugo-github-issue-8729
hugo server

@bep bep added the Bug label Jul 6, 2021
@bep bep added this to the v0.86 milestone Jul 6, 2021
@bep
Copy link
Member

@bep bep commented Jul 6, 2021

The (my) upstream encoder works correctly here: bep/gowebp@a20a4da

Which narrows down the options ...

bep added a commit to bep/hugo that referenced this issue Jul 7, 2021
@bep
Fix transparency problem when converting 32-bit images to WebP
Verified
This commit was signed with the committer’s verified signature.
bep Bjørn Erik Pedersen
GPG key ID: 330E6E2BD4859D8F Learn about vigilant mode.
Loading status checks…
93a3e7c 
Fixes gohugoio#8729
@bep bep mentioned this issue Jul 7, 2021
Merged
bep added a commit to bep/hugo that referenced this issue Jul 7, 2021
@bep
resources: Regenerate image golden testdata
Verified
This commit was signed with the committer’s verified signature.
bep Bjørn Erik Pedersen
GPG key ID: 330E6E2BD4859D8F Learn about vigilant mode.
Loading status checks…
535cfd5 
Keep this as a separate commit as this isn't because the files have changed. The filenames have changed due to cache busting of PNG and Webp images.

See gohugoio#8729
bep added a commit to bep/hugo that referenced this issue Jul 7, 2021
@bep
resources: Regenerate image golden testdata
Verified
This commit was signed with the committer’s verified signature.
bep Bjørn Erik Pedersen
GPG key ID: 330E6E2BD4859D8F Learn about vigilant mode.
Loading status checks…
bf3bdbe 
Keep this as a separate commit as this isn't because the files have changed. The filenames have changed due to cache busting of PNG and Webp images.

See gohugoio#8729
@bep bep closed this in #8730 Jul 7, 2021
bep added a commit that referenced this issue Jul 7, 2021
@bep
Fix transparency problem when converting 32-bit images to WebP
8f40f34 
Fixes #8729
bep added a commit that referenced this issue Jul 7, 2021
@bep
resources: Regenerate image golden testdata
Loading status checks…
30eea39 
Keep this as a separate commit as this isn't because the files have changed. The filenames have changed due to cache busting of PNG and Webp images.

See #8729
@github-actions github-actions bot mentioned this issue Jul 21, 2021
Merged
@bot-actions bot-actions bot mentioned this issue Jul 23, 2021
Merged
@abtris abtris mentioned this issue Jul 26, 2021
Merged
@abtris abtris mentioned this issue Jul 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
v0.86
Linked pull requests

Successfully merging a pull request may close this issue.

Fix transparency problem when converting 32-bit images to WebP
2 participants
@jmooring @bep