Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transparency problem when converting 32-bit images to WebP #8729

Closed
jmooring opened this issue Jul 6, 2021 · 3 comments · Fixed by #8730
Closed

Transparency problem when converting 32-bit images to WebP #8729

jmooring opened this issue Jul 6, 2021 · 3 comments · Fixed by #8730
Labels
Bug Outdated
Milestone
v0.86

Comments

@jmooring
Copy link
Member

jmooring commented Jul 6, 2021

Example:

image

Minimal reproducible example to follow...
@jmooring
Copy link
Member Author

jmooring commented Jul 6, 2021

Minimal reproducible example:

git clone --single-branch -b hugo-github-issue-8729 https://github.com/jmooring/hugo-testing hugo-github-issue-8729
cd hugo-github-issue-8729
hugo server

@bep bep added the Bug label Jul 6, 2021
@bep bep added this to the v0.86 milestone Jul 6, 2021
@bep
Copy link
Member

bep commented Jul 6, 2021

The (my) upstream encoder works correctly here: bep/gowebp@a20a4da

Which narrows down the options ...

bep added a commit to bep/hugo that referenced this issue Jul 7, 2021
@bep
Fix transparency problem when converting 32-bit images to WebP
93a3e7c 
Fixes gohugoio#8729
@bep bep mentioned this issue Jul 7, 2021
Merged
bep added a commit to bep/hugo that referenced this issue Jul 7, 2021
@bep
resources: Regenerate image golden testdata
535cfd5 
Keep this as a separate commit as this isn't because the files have changed. The filenames have changed due to cache busting of PNG and Webp images.

See gohugoio#8729
bep added a commit to bep/hugo that referenced this issue Jul 7, 2021
@bep
resources: Regenerate image golden testdata
bf3bdbe 
Keep this as a separate commit as this isn't because the files have changed. The filenames have changed due to cache busting of PNG and Webp images.

See gohugoio#8729
@bep bep closed this as completed in #8730 Jul 7, 2021
bep added a commit that referenced this issue Jul 7, 2021
@bep
Fix transparency problem when converting 32-bit images to WebP
8f40f34 
Fixes #8729
bep added a commit that referenced this issue Jul 7, 2021
@bep
resources: Regenerate image golden testdata
30eea39 
Keep this as a separate commit as this isn't because the files have changed. The filenames have changed due to cache busting of PNG and Webp images.

See #8729
@github-actions github-actions bot mentioned this issue Jul 21, 2021
Merged
@bot-actions bot-actions bot mentioned this issue Jul 23, 2021
Merged
This was referenced Jul 26, 2021
Merged
Merged
@mal-tee mal-tee mentioned this issue Sep 24, 2021
Merged
@olblak olblak mentioned this issue Oct 8, 2021
Merged
anthonyfok added a commit to anthonyfok/hugo that referenced this issue Oct 29, 2021
@anthonyfok
resources: Rename excepted filenames for image golden testdata
4fae926 
As documented in commit 30eea39,
some filenames have changed due to cache busting of PNG and Webp images.

This resolves recent TestImageOperationsGolden failure on arm64, ppc64le
and s390x.

See gohugoio#6387 and gohugoio#8729
@anthonyfok anthonyfok mentioned this issue Oct 29, 2021
Merged
bep pushed a commit that referenced this issue Oct 30, 2021
@anthonyfok @bep
resources: Rename excepted filenames for image golden testdata
dce49d1 
As documented in commit 30eea39,
some filenames have changed due to cache busting of PNG and Webp images.

This resolves recent TestImageOperationsGolden failure on arm64, ppc64le
and s390x.

See #6387 and #8729
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug Outdated
Projects
None yet
Milestone
v0.86
Development

Successfully merging a pull request may close this issue.

Fix transparency problem when converting 32-bit images to WebP bep/hugo
2 participants
@jmooring @bep