Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check binary size vs locale #8839

Closed
bep opened this issue Aug 2, 2021 · 1 comment · Fixed by #8842
Closed

Check binary size vs locale #8839

bep opened this issue Aug 2, 2021 · 1 comment · Fixed by #8842
Labels
Enhancement Outdated
Milestone
v0.87

Comments

@bep
Copy link
Member

bep commented Aug 2, 2021

Adding 700 locale structs to the build has its cost, this is with -s -w build flags:

-rwxr-xr-x   1 bep  staff  46075328 Jul 29 19:05 hugo_086
-rwxr-xr-x   1 bep  staff  77101744 Jul 29 19:08 hugo_now

The extra 30MB doesn't bother me very much, but I know other will.
@bep bep added the Enhancement label Aug 2, 2021
@bep bep added this to the v0.87 milestone Aug 2, 2021
@bep bep mentioned this issue Aug 2, 2021
Merged
bep added a commit to bep/hugo that referenced this issue Aug 2, 2021
@bep
Reduce binary size vs locale, update to CLDR v36.1
0114268 
Test building with `go build -ldflags="-s -w"`

Hugo 0.86.2: 46MB
Before this commit: 77MB
After this commit: 54MB

Fixes gohugoio#8839
Fixes gohugoio#8841
@bep bep closed this as completed in #8842 Aug 2, 2021
bep added a commit that referenced this issue Aug 2, 2021
@bep
Reduce binary size vs locale, update to CLDR v36.1
3a96655 
Test building with `go build -ldflags="-s -w"`

Hugo 0.86.2: 46MB
Before this commit: 77MB
After this commit: 54MB

Fixes #8839
Fixes #8841
@bot-actions bot-actions bot mentioned this issue Aug 4, 2021
Merged
This was referenced Aug 9, 2021
Merged
Merged
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Enhancement Outdated
Projects
None yet
Milestone
v0.87
Development

Successfully merging a pull request may close this issue.

Reduce binary size vs locale, update to CLDR v36.1 bep/hugo
1 participant
@bep