Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error for codeblock render hook #9892

Closed
bep opened this issue May 13, 2022 · 1 comment
Closed

Improve error for codeblock render hook #9892

bep opened this issue May 13, 2022 · 1 comment

Comments

@bep
Copy link
Member

bep commented May 13, 2022

We already have a way to determine its Position so we might as well use it to point to the place in the content file where it fails:

image

@bep bep added this to the v0.99.0 milestone May 13, 2022
bep added a commit to bep/hugo that referenced this issue May 13, 2022
* Redo the server error template
* Always add the content file context if relevant
* Remove some now superflous error string matching
* Move the server error template to _server/error.html
* Add file context (with position) to codeblock render blocks
* Improve JS build errors

Fixes gohugoio#9892
Fixes gohugoio#9891
bep added a commit to bep/hugo that referenced this issue May 14, 2022
* Redo the server error template
* Always add the content file context if relevant
* Remove some now superflous error string matching
* Move the server error template to _server/error.html
* Add file context (with position) to codeblock render blocks
* Improve JS build errors

Fixes gohugoio#9892
Fixes gohugoio#9891
bep added a commit to bep/hugo that referenced this issue May 14, 2022
* Redo the server error template
* Always add the content file context if relevant
* Remove some now superflous error string matching
* Move the server error template to _server/error.html
* Add file context (with position) to codeblock render blocks
* Improve JS build errors

Fixes gohugoio#9892
Fixes gohugoio#9891
Fixes gohugoio#9893
@bep bep closed this as completed in 5c96bda May 14, 2022
@github-actions
Copy link

github-actions bot commented Jun 5, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant