-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make HTML behave exactly like other content formats #12008
Conversation
e35db3b
to
d20c183
Compare
d20c183
to
b38beec
Compare
@jmooring this should be a controlled change as I have just "removed lots of code". I have added some test cases, but it would be good if you could have a look. |
Using this example...
This content...
Produces these results...
I think the second one should be a page resources to be consistent with how we handle the other content formats. |
I will have a look (but I do suspect you would see the same if you add |
When we have two images (non-content resources) with the same base name there is no collision; both are available as resources, and both are copied to public. But when we have two content files (content resources) with the same base name, only one is available as a resource. Not sure which one wins. |
I need to take that issue (which is not related to this particular issue) in #12013 -- we currently pick one of the versions (based on a consistent sort order), which makes sense for regular pages, possibly not for page resources ... but it's hard to distinguish the two at this point, so I suspect I need to print a warning about it -- I don't see why you would need two content files with the same name. Other than that ... this is OK? |
Yes! |
This currently only contains a test that illustrates the issue.
Without digging down trying to find the reason why this has changed, I think we agree that the current behaviour is less than useful, and that if we're going to break anything, we might as well break it in the direction of useful.
What if we say that we start treating all content files the same (Markdown, HTML, Asciidoc etc.).
Does that sound like a plan?