Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slicestr param fix #1352

Closed
wants to merge 6 commits into from
Closed

Slicestr param fix #1352

wants to merge 6 commits into from

Conversation

benzwu
Copy link
Contributor

@benzwu benzwu commented Aug 14, 2015

Changes:

  • Take out toInt
  • SliceStr param changes from int to interface
  • convert to int for SliceStr params (toInt)
  • update template_funcs_test test case, switch from array param to regular param.

fix for #1347


I don't have knowledge on go and workflow in developing one, I had to copy everything out, manually test and put back in manually. Your suggestions appreciated.

benzwu and others added 4 commits August 11, 2015 09:33
using the new BashCompSubdirsInDir annotation in spf13/cobra.
SliceStr param changes from int to interface
convert to int for SliceStr paramupdate template_funcs_test test case, switch from array param to regular param.
@benzwu benzwu changed the title Slicestr substr fix Slicestr param fix Aug 14, 2015
@benzwu benzwu closed this Aug 14, 2015
@benzwu benzwu reopened this Aug 14, 2015
@tatsushid
Copy link
Contributor

This PR includes some other fixes not related to Slicestr. Please create a new branch from the tip of the master branch for this fix, put your changes in it and make a PR?

@tatsushid
Copy link
Contributor

And before making a PR, please test it on your machine. It is easy to do it just running

go test ./...

in your Hugo directory.

@benzwu
Copy link
Contributor Author

benzwu commented Aug 14, 2015

thanks for your guide. Will do. closing this.

@benzwu benzwu closed this Aug 14, 2015
@benzwu benzwu deleted the slicestr-substr-fix branch August 14, 2015 03:24
@github-actions
Copy link

github-actions bot commented Mar 1, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants