Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slicestr fix for other int type param #1353

Closed
wants to merge 1 commit into from

Conversation

benzwu
Copy link
Contributor

@benzwu benzwu commented Aug 14, 2015

Changes:

  • Take out toInt
  • SliceStr param changes from int to interface
  • convert to int for SliceStr params (toInt)
  • update template_funcs_test test case, switch from array param to regular param.

fix for #1347

@bep
Copy link
Member

bep commented Aug 14, 2015

Merged in 5b51b3b

Note the small addition to your commit message.

@bep bep closed this Aug 14, 2015
@bep
Copy link
Member

bep commented Aug 14, 2015

On an added note: Your contributions are excellent! I like pull requests I can just merge.

@github-actions
Copy link

github-actions bot commented Mar 1, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants