Content, layout config opt made available via command line #1698
Conversation
|
Is this okay or should I instead add an additional argument to |
|
Please don't add an additional argument. The current approach you are taking is sound. I would rename your function to something else. It's not simpler than AbsPathify as it takes an additional argument. |
|
when you have this ready, please rebase from master and force push. |
|
👍 ok |
kujohn
force-pushed
the
devel/1598
branch
3 times, most recently
from
431f075
to
2752d9f
Compare
|
Squashed and rebased, this should be good to go after code review. |
kujohn
changed the title
|
@kujohn could you rebase this against master ... again; sorry for that :-) |
kujohn
force-pushed
the
devel/1598
branch
2 times, most recently
from
2ced457
to
c5b51ab
Compare
|
Had some issue rebasing. Be back in an hour. 😭 |
kujohn
force-pushed
the
devel/1598
branch
4 times, most recently
from
9d4140e
to
f8f32a4
Compare
|
Rebased correctly I think. |
| var layoutPath string | ||
|
|
||
| if layoutDir != "" { | ||
| layoutPath = helpers.AbsPathifySimple(viper.GetString("LayoutDir")) |
There was a problem hiding this comment.
Why AbsPathifySimple? These new dir flags should behave exactly as the others. If there is some issue with AbsPathify, then that should be addressed in a separate issue.
There was a problem hiding this comment.
If the working directory is set, this allows relative layout/content path to be set independently and working.
Perhaps this feature is not needed yet or that this func needs to be renamed?
This is another issue not relevant to this issue. Remove that function and use the existing. |
kujohn
force-pushed
the
devel/1598
branch
3 times, most recently
from
c54e34b
to
92a0314
Compare
|
ok squashed and cleaned up. |
|
lgtm |
|
Looks good to me, too, thanks. Merged in 0ab4162 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
I want to get some feedback before working further.
fixes #1598