New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content, layout config opt made available via command line #1698

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
@kujohn
Contributor

kujohn commented Dec 10, 2015

I want to get some feedback before working further.
fixes #1598

@kujohn

This comment has been minimized.

Show comment
Hide comment
@kujohn

kujohn Dec 10, 2015

Contributor

Is this okay or should I instead add an additional argument to helper.AbsPathify for opt in of using WorkingDir? There's a todo comment here.

Contributor

kujohn commented Dec 10, 2015

Is this okay or should I instead add an additional argument to helper.AbsPathify for opt in of using WorkingDir? There's a todo comment here.

@spf13

This comment has been minimized.

Show comment
Hide comment
@spf13

spf13 Dec 24, 2015

Contributor

Please don't add an additional argument. The current approach you are taking is sound.

I would rename your function to something else. It's not simpler than AbsPathify as it takes an additional argument.

Contributor

spf13 commented Dec 24, 2015

Please don't add an additional argument. The current approach you are taking is sound.

I would rename your function to something else. It's not simpler than AbsPathify as it takes an additional argument.

@spf13

This comment has been minimized.

Show comment
Hide comment
@spf13

spf13 Jan 6, 2016

Contributor

when you have this ready, please rebase from master and force push.

Contributor

spf13 commented Jan 6, 2016

when you have this ready, please rebase from master and force push.

@kujohn

This comment has been minimized.

Show comment
Hide comment
@kujohn

kujohn Jan 6, 2016

Contributor

👍 ok

Contributor

kujohn commented Jan 6, 2016

👍 ok

@kujohn

This comment has been minimized.

Show comment
Hide comment
@kujohn

kujohn Jan 8, 2016

Contributor

Squashed and rebased, this should be good to go after code review.

Contributor

kujohn commented Jan 8, 2016

Squashed and rebased, this should be good to go after code review.

@kujohn kujohn changed the title from content, layout config opt made available via command line to Content, layout config opt made available via command line Jan 8, 2016

@bep

This comment has been minimized.

Show comment
Hide comment
@bep

bep Mar 10, 2016

Member

@kujohn could you rebase this against master ... again; sorry for that :-)

Member

bep commented Mar 10, 2016

@kujohn could you rebase this against master ... again; sorry for that :-)

@kujohn

This comment has been minimized.

Show comment
Hide comment
@kujohn

kujohn Mar 10, 2016

Contributor

Had some issue rebasing. Be back in an hour. 😭

Contributor

kujohn commented Mar 10, 2016

Had some issue rebasing. Be back in an hour. 😭

@kujohn

This comment has been minimized.

Show comment
Hide comment
@kujohn

kujohn Mar 10, 2016

Contributor

Rebased correctly I think.

Contributor

kujohn commented Mar 10, 2016

Rebased correctly I think.

@bep

View changes

Show outdated Hide outdated commands/hugo.go
var layoutPath string
if layoutDir != "" {
layoutPath = helpers.AbsPathifySimple(viper.GetString("LayoutDir"))

This comment has been minimized.

@bep

bep Mar 10, 2016

Member

Why AbsPathifySimple? These new dir flags should behave exactly as the others. If there is some issue with AbsPathify, then that should be addressed in a separate issue.

@bep

bep Mar 10, 2016

Member

Why AbsPathifySimple? These new dir flags should behave exactly as the others. If there is some issue with AbsPathify, then that should be addressed in a separate issue.

This comment has been minimized.

@kujohn

kujohn Mar 11, 2016

Contributor

If the working directory is set, this allows relative layout/content path to be set independently and working.
Perhaps this feature is not needed yet or that this func needs to be renamed?

@kujohn

kujohn Mar 11, 2016

Contributor

If the working directory is set, this allows relative layout/content path to be set independently and working.
Perhaps this feature is not needed yet or that this func needs to be renamed?

@bep

This comment has been minimized.

Show comment
Hide comment
@bep

bep Mar 11, 2016

Member

Perhaps this feature is not needed yet or that this func needs to be renamed?

This is another issue not relevant to this issue. Remove that function and use the existing.

Member

bep commented Mar 11, 2016

Perhaps this feature is not needed yet or that this func needs to be renamed?

This is another issue not relevant to this issue. Remove that function and use the existing.

@kujohn

This comment has been minimized.

Show comment
Hide comment
@kujohn

kujohn Mar 11, 2016

Contributor

ok squashed and cleaned up.

Contributor

kujohn commented Mar 11, 2016

ok squashed and cleaned up.

@moorereason

This comment has been minimized.

Show comment
Hide comment
@moorereason

moorereason Mar 11, 2016

Contributor

lgtm

Contributor

moorereason commented Mar 11, 2016

lgtm

@bep

This comment has been minimized.

Show comment
Hide comment
@bep

bep Mar 11, 2016

Member

Looks good to me, too, thanks. Merged in 0ab4162

Member

bep commented Mar 11, 2016

Looks good to me, too, thanks. Merged in 0ab4162

@bep bep closed this Mar 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment