-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Press page remove dead links and YYYY-MM-DD date format #3175
Conversation
This page was a real chore chore on the POC. In the event that a new doc site won't be approved by v20, this will at least clean up the broken links I found during my audit. I would like to eventually create this as a [data file](#2508 (comment)) since md tables get unwieldy pretty quickly.
@rdwatters, Thank you for your great work in cleaning up the list of Press articles!
Actually, the existing formatting is consistent, depending on one’s point of view. The seemingly random spaces are there so that the column widths are consistent and everything would line up. It has been like that since the beginning when @spf13 started it, supposedly because it is an automatic feature of vim-spf13: whenever you edit a row, upon typing But of course, the problem here is that each line is like 300 characters long, and one would have to have a really large monitor, or make the font in the terminal really small, to see the full-width of the almost-perfectly-lined-up table. :-p (I am partially guilty of making the table that wide because I decided to add So, which is more consistent? Strictly one space before and after each That said, I think re-implementing that page using data files is a marvellous idea! 👍 |
This page predates data files. The switch to them is long overdue.
…On Mon, Mar 13, 2017 at 12:59 PM Anthony Fok ***@***.***> wrote:
@rdwatters <https://github.com/rdwatters>, Thank you for your great work
in cleaning up the list of Press articles!
Just one comment:
make formatting consistent
Actually, the existing formatting *is* consistent, depending on one’s
point of view. The seemingly random spaces are there so that the column
widths are consistent and everything would line up. It has been like that
since the beginning when @spf13 <https://github.com/spf13> started it,
supposedly because it is an automatic feature of vim-spf13
<http://vim.spf13.com/>: whenever you edit a row, upon typing |, a vim
plugin included in vim-spf13 automatically makes everything line up!
But of course, the problem here is that each line is like 300 characters
long, and one would have to have a really large monitor, or make the font
in the terminal really small, to see the full-width of the
almost-perfectly-lined-up table. :-p (I am partially guilty of making the
table that wide because I decided to add <span lang="xx"> markups for
foreign languages.) And indeed, most people who have made pull requests to
add links didn't know that, and I recall making several commits in the past
to re-align those added rows.
So, which is more consistent? Strictly one space before and after each |
character? Or padding with as many spaces as necessary to equal column
widths? I don't know either.
That said, I think re-implementing that page using data files is a
marvellous idea! 👍
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3175 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAKlZCWhi6dMAdxonTH4hDiKpxofYXBBks5rlXXdgaJpZM4Mbdsr>
.
|
Ah, I should have been clearer @anthonyfok. I agree the parts you already mention are consistent. I meant the date formatting, etc, which is now easier to see at a glance with YYYY-MM-DD. The spacing between the rows in the table wasn't what I was referring to and didn't necessarily both me. I made it tighter in spacing mostly for OCD-related reasons...
Agreed: rdwatters/hugo-docs-concept#19 |
FTR @anthonyfok here it is in TOML in the event we can't get the new docs site up in time for v20 (or we can just wait 😄 ). |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This page was a real chore chore on the POC. In the event that a new doc site won't be approved by v20, this will at least clean up the broken links I found during my audit. I would like to eventually create this as a data file since md tables get unwieldy quickly.