Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hugolib: Remove empty resources/ dir after TestNewSiteDefaultLang #4922

Conversation

anthonyfok
Copy link
Member

While packaging Hugo v0.43 for Debian, the Lintian tool informed me of the following:

I: golang-github-gohugoio-hugo-dev: package-contains-empty-directory usr/share/gocode/src/github.com/gohugoio/hugo/hugolib/resources/

This is something new to v0.43. I wonder what changed. Hmm...

After some testing, it was found that the hugolib/resources/ directory was created during go test run, reproducible by running:

go test -v ./hugolib/... -run TestNewSiteDefaultLang

It is a very trivial issue, and this PR of adding defer os.Remove("resources") is likely not the proper fix either, but I thought I should report it nevertheless.

@bep bep merged commit 4108705 into gohugoio:master Jul 10, 2018
@github-actions
Copy link

github-actions bot commented Feb 4, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants