New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix various Windows-issues #699
Conversation
0db5c5b
to
0b6594c
Compare
I've done some quick, manual testing of 4-5 Hugo sites on both Win and Linux -- and It doesn't look like I have broken "anything important". |
File handling was broken on Windows. This commit contains a revision of the path handling with separation of file paths and urls where needed. There may be remaining issues and there may be better ways to do this, but it is easier to start that refactoring job with a set of passing tests. Fixes gohugoio#687 Fixes gohugoio#660
@spf13 and then the build was all green. |
@bjornerik Awesome job. Thanks so much for taking the time and effort to resolve this. |
👍 Yes, yes, yes. |
👍 |
Merged as 9f77f93 |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
File handling was broken on Windows. This commit contains a revision of the path handling with separation of file paths and urls where needed.
There may be remaining issues and there may be better ways to do this, but it is easier to start that refactoring job with a set of passing tests.
Fixes #687
Fixes #660