Allow for return partials with falsy arguments #9298
Conversation
|
|
|
Thanks for this, I thought long and hard about this problem ... never thought about using the |
| @@ -112,7 +112,7 @@ func getParseTree(templ tpl.Template) *parse.Tree { | |||
| } | |||
|
|
|||
| const ( | |||
| partialReturnWrapperTempl = `{{ $_hugo_dot := $ }}{{ $ := .Arg }}{{ with .Arg }}{{ $_hugo_dot.Set ("PLACEHOLDER") }}{{ end }}` | |||
| partialReturnWrapperTempl = `{{ $_hugo_dot := $ }}{{ $ := .Arg }}{{ range (slice .Arg) }}{{ $_hugo_dot.Set ("PLACEHOLDER") }}{{ end }}` | |||
There was a problem hiding this comment.
I suspect it would be easier to understand if you make contextWrapper.Arg a []interface{} -- and just add a comment there explaining why it's a slice with a single value.
There was a problem hiding this comment.
I gave this a go, though my attempt at a comment depended on explaining what we were doing with the partialReturnWrapperTempl. In the end, I found it simpler to add a comment above partialReturnWrapperTempl while leaving contextWrapper.Arg as it was. How does that sound?
Partials with returns values are parsed, then inserted into a partial return wrapper via wrapInPartialReturnWrapper in order to assign the return value via *contextWrapper.Set. The predefined wrapper template for partials inserts a partial's nodes into a "with" template action in order to set dot to a *contextWrapper within the partial. However, because "with" is skipped if its argument is falsy, partials with falsy arguments were not being evaluated. This replaces the "with" action in the partial wrapper with a "range" action that isn't skipped if .Arg is falsy. Fixes gohugoio#7528
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Partials with returns values are parsed, then inserted into a
partial return wrapper via wrapInPartialReturnWrapper in order
to assign the return value via *contextWrapper.Set. The
predefined wrapper template for partials inserts a partial's nodes
into a "with" template action in order to set dot to a
*contextWrapper within the partial. However, because "with" is
skipped if its argument is falsy, partials with falsy arguments
were not being evaluated.
This replaces the "with" action in the partial wrapper with a
"range" action that isn't skipped if .Arg is falsy.
Fixes #7528