Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation for Ugly URLs #1082

Merged
merged 3 commits into from
Jun 14, 2020
Merged

Update documentation for Ugly URLs #1082

merged 3 commits into from
Jun 14, 2020

Conversation

MauriceBrg
Copy link
Contributor

@MauriceBrg MauriceBrg commented Apr 12, 2020 •
edited
Loading

Update documentation to replace the CLI-Argument with an environment variable as the CLI-argument no longer exists.

References:

@MauriceBrg
Update urls.md
75f2507 
Update documentation to reflect status of this issue - (the --uglyurls CLI parameter no longer exists)
gohugoio/hugo#4428

See also: https://gohugo.io/getting-started/configuration/#configure-with-environment-variables
@MauriceBrg
Merge pull request #1 from MauriceBrg/MauriceBrg-fix-doc
8278b57 
Update urls.md
@CLAassistant
Copy link

CLAassistant commented Apr 12, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

davidsneighbour
davidsneighbour suggested changes Jun 11, 2020
View reviewed changes
Copy link
Contributor

@davidsneighbour davidsneighbour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change "You can also use set" to "You can also set" and we are good to go :)

@MauriceBrg
Update urls.md
359fbdf 
Remove a "use" that was not necessary.
@MauriceBrg
Copy link
Contributor Author

@davidsneighbour
Done :)

davidsneighbour
davidsneighbour approved these changes Jun 14, 2020
View reviewed changes
Copy link
Contributor

@davidsneighbour davidsneighbour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go.

@davidsneighbour davidsneighbour merged commit ac2c4a4 into gohugoio:master Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsneighbour davidsneighbour davidsneighbour approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MauriceBrg @CLAassistant @davidsneighbour