Binarify ejabberd_s2s:parent_domains/1

Fixes esl#27 on GitHub
goj · Jun 4, 2012 · 470bbf8 · 470bbf8
1 parent 407f43a
commit 470bbf8
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/apps/ejabberd/src/ejabberd_s2s.erl b/apps/ejabberd/src/ejabberd_s2s.erl
@@ -418,12 +418,14 @@ is_service(From, To) ->
     end.
 
 parent_domains(Domain) ->
-    lists:foldl(
-      fun(Label, []) ->
-	      [Label];
-	 (Label, [Head | Tail]) ->
-	      [Label ++ "." ++ Head, Head | Tail]
-      end, [], lists:reverse(string:tokens(Domain, "."))).
+    parent_domains(Domain, [Domain]).
+
+parent_domains(<<>>, Acc) ->
+    lists:reverse(Acc);
+parent_domains(<<$., Rest/binary>>, Acc) ->
+    parent_domains(Rest, [Rest | Acc]);
+parent_domains(<<_, Rest/binary>>, Acc) ->
+    parent_domains(Rest, Acc).
 
 send_element(Pid, El) ->
     Pid ! {send_element, El}.