Requeue in progress jobs and clean stale lock info on stop #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case there is a failover with a Redis Sentinel cluster with data loss there can be stale lock information which can cause job processing to be stuck if the max concurrency limit is reached. Therefore, re-enqueue the jobs which were in progress and also clean the stale lock info for the worker pool. For the cleanup to be thorough, the stop would need to be called on each worker pool instance.
sudo-suhas
force-pushed
the
cleanup-on-shutdown
branch
2 times, most recently
from
85cc769
to
72ebe01
Compare
sudo-suhas
force-pushed
the
cleanup-on-shutdown
branch
from
72ebe01
to
1d9521b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case there is a failover with a Redis Sentinel cluster with data loss
there can be stale lock information which can cause job processing to be
stuck if the max concurrency limit is reached. Therefore, re-enqueue the
jobs which were in progress and also clean the stale lock info for the
worker pool.
For the cleanup to be thorough, the stop would need to be called on each
worker pool instance.