Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for providing topic-name in the metrics #48

Closed
wants to merge 1 commit into from
Closed

add support for providing topic-name in the metrics #48

wants to merge 1 commit into from

Conversation

macalimlim
Copy link
Contributor

No description provided.

kartik7153
kartik7153 reviewed May 27, 2019
View reviewed changes
Copy link
Member

@kartik7153 kartik7153 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think make-histogram is not the only one. We should make the changes to increment-count as well.

@macalimlim
Copy link
Contributor Author

closing this, please refer to my new PR #49

@macalimlim macalimlim closed this May 27, 2019
@macalimlim macalimlim deleted the goj-88147 branch May 28, 2019 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kartik7153 kartik7153 kartik7153 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@macalimlim @kartik7153