Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backspace in rename prompt causes unexpected behavior #1059

Closed
karabaja4 opened this issue Dec 28, 2022 · 2 comments
Closed

Backspace in rename prompt causes unexpected behavior #1059

karabaja4 opened this issue Dec 28, 2022 · 2 comments

Comments

@karabaja4
Copy link

A regression from lf 27 in lf 28:

If you try to rename a file and hold the backspace key to delete the whole filename, it will not stop at the beginning of the prompt, instead when it reaches the beginning it will exit the rename and start triggering the backspace key (if you have it mapped to something, it will execute that action unexpectedly).

I had backspace mapped to updir, so when I held the backspace key to change the filename, suddenly I found myself looking at the / directory.

@SeekingBlues
Copy link
Contributor

Similar issue: #1052

ilyagr added a commit to ilyagr/lf that referenced this issue Dec 28, 2022
After looking at the list of possibilities for `app.ui.cmdPrefix`
by searching through the code, renaming is the only remaining mode
where exiting via backspace doesn't make sense.

If I missed something, please let me know. I can fix it here
or in a subsequent PR, depending on when we find out.

Fixes gokcehan#1052, gokcehan#1059
gokcehan pushed a commit that referenced this issue Feb 11, 2023
After looking at the list of possibilities for `app.ui.cmdPrefix` by searching
through the code, renaming looks to be the only remaining mode where exiting
via backspace doesn't make sense.

In particular, I don't think any commands other than `rename` commonly start
out with some editable text in the prompt. The other dangerous mode is the `>`
mode, but there exit-on-backspace was already disabled.

Fixes #1052, #1059
@joelim-work
Copy link
Collaborator

joelim-work commented Mar 28, 2023

This is actually fixed in #1060 and can be closed. It turns out this issue wasn't linked properly because Fixes has to be specified for each individual issue in the PR description if there are multiple issues being linked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants