Disallow exiting from rename: mode with backspace
#1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyagr
force-pushed
the
no_bkspace
branch
2 times, most recently
from
74a564d
to
13dff26
Compare
After looking at the list of possibilities for `app.ui.cmdPrefix` by searching through the code, renaming looks to be the only remaining mode where exiting via backspace doesn't make sense. In particular, I don't think any commands other than `rename` commonly start out with some editable text in the prompt. The other dangerous mode is the `>` mode, but there exit-on-backspace was already disabled. Fixes gokcehan#1052, gokcehan#1059
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After looking at the list of possibilities for
app.ui.cmdPrefixby searching through the code, renaming looks to be the only remaining mode where exiting via backspace doesn't make sense.In particular, I don't think any commands other than
renamecommonly start out with some editable text in the prompt. The other dangerous mode is the>mode, but there exit-on-backspace was already disabled.If I missed something, please let me know. I can fix it here or in a subsequent PR, depending on when we find out.
Fixes #1052, #1059