Add a SquashFS writer #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @plougher :) |
The dirInodeHeader type only uses a uint16 for the size of the directory entries, which is sometimes not sufficient (and before this change would overflow, resulting in directories which seemed to miss files).
This reduces the time to generate images for my largest gokrazy installation from 3.5s to 1.6s, while only increasing the file size from 32M to 36M.
|
Since I was unable to get a review on this, I wrote a tool to generate Squashfs images from the extracted orig tarballs of all Debian packages, then verify that This tool confirmed the code works fine for all 30162 orig tarballs I tested it with, so I’m reasonably confident :). I don’t intend to maintain the verification tool so I’m not including it in this PR, but you can find it at https://gist.github.com/stapelberg/2264acd713fed3ae58594ce4d4476c50 if you’re curious. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.