Using jwt's native ErrInvalidType instead of json.UnsupportedTypeError
#316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rror` Previously, when parsing claim values, we used `json.UnsupportedTypeError` to denote if a claim string value is not of the correct type. However, this could lead to panics if a nil value is present and the `Error` function of the `json.UnsupportedTypeError` is called, which does not check for nil types. Instead, we just now use `ErrInvalidType` similar to the map claims. Fixes #315
mfridman
approved these changes
Jun 9, 2023
renovate bot
added a commit
to woodpecker-ci/woodpecker
that referenced
this pull request
Nov 13, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/golang-jwt/jwt/v5](https://togithub.com/golang-jwt/jwt) | require | minor | `v5.0.0` -> `v5.1.0` | | golang.org/x/crypto | require | minor | `v0.14.0` -> `v0.15.0` | | golang.org/x/net | require | minor | `v0.17.0` -> `v0.18.0` | | golang.org/x/oauth2 | require | minor | `v0.13.0` -> `v0.14.0` | | golang.org/x/term | require | minor | `v0.13.0` -> `v0.14.0` | --- ### Release Notes <details> <summary>golang-jwt/jwt (github.com/golang-jwt/jwt/v5)</summary> ### [`v5.1.0`](https://togithub.com/golang-jwt/jwt/releases/tag/v5.1.0) [Compare Source](https://togithub.com/golang-jwt/jwt/compare/v5.0.0...v5.1.0) #### What's Changed - Using jwt's native `ErrInvalidType` instead of `json.UnsupportedTypeError` by [@​oxisto](https://togithub.com/oxisto) in [golang-jwt/jwt#316 - Fix typos in comments and test names by [@​alexandear](https://togithub.com/alexandear) in [golang-jwt/jwt#317 - Format: add whitespaces, remove empty lines by [@​alexandear](https://togithub.com/alexandear) in [golang-jwt/jwt#319 - Refactor example: use io.ReadAll instead of io.Copy by [@​alexandear](https://togithub.com/alexandear) in [golang-jwt/jwt#320 - Refactor code by using switch instead of if-else by [@​alexandear](https://togithub.com/alexandear) in [golang-jwt/jwt#318 - A quick way to validate token string by [@​dcalsky](https://togithub.com/dcalsky) in [golang-jwt/jwt#302 - Refactor: remove unnecessary \[]byte conversion to string by [@​alexandear](https://togithub.com/alexandear) in [golang-jwt/jwt#330 - Refactor: compare strings with strings.EqualFold by [@​alexandear](https://togithub.com/alexandear) in [golang-jwt/jwt#329 - Avoid use of json.NewDecoder by [@​craigpastro](https://togithub.com/craigpastro) in [golang-jwt/jwt#313 - Update ParseUnverified godoc by [@​duhaesbaert](https://togithub.com/duhaesbaert) in [golang-jwt/jwt#341 - Update ci workflows (add go1.21) by [@​mfridman](https://togithub.com/mfridman) in [golang-jwt/jwt#345 - Bump actions/checkout from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [golang-jwt/jwt#346 - Key rotation with VerificationKeySet by [@​mfridman](https://togithub.com/mfridman) in [golang-jwt/jwt#344 - Add explicit ClaimsValidator implementation check for custom claims by [@​epelc](https://togithub.com/epelc) in [golang-jwt/jwt#343 - feat: allow making exp claim required by [@​tareksha](https://togithub.com/tareksha) in [golang-jwt/jwt#351 - Add error handling to examples by [@​craigpastro](https://togithub.com/craigpastro) in [golang-jwt/jwt#312 #### New Contributors - [@​alexandear](https://togithub.com/alexandear) made their first contribution in [golang-jwt/jwt#317 - [@​dcalsky](https://togithub.com/dcalsky) made their first contribution in [golang-jwt/jwt#302 - [@​craigpastro](https://togithub.com/craigpastro) made their first contribution in [golang-jwt/jwt#313 - [@​duhaesbaert](https://togithub.com/duhaesbaert) made their first contribution in [golang-jwt/jwt#341 - [@​epelc](https://togithub.com/epelc) made their first contribution in [golang-jwt/jwt#343 - [@​tareksha](https://togithub.com/tareksha) made their first contribution in [golang-jwt/jwt#351 **Full Changelog**: golang-jwt/jwt@v5.0.0...v5.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am" (UTC), Automerge - "before 4am" (UTC). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/woodpecker-ci/woodpecker). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40Ni4wIiwidXBkYXRlZEluVmVyIjoiMzcuNDYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
nono
added a commit
to cozy/cozy-stack
that referenced
this pull request
Nov 20, 2023
](https://renovatebot.com){kind=link}
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/golang-jwt/jwt/v5](https://togithub.com/golang-jwt/jwt) | require | minor | `v5.0.0` -> `v5.1.0` | --- ### Release Notes <details> <summary>golang-jwt/jwt (github.com/golang-jwt/jwt/v5)</summary> ### [`v5.1.0`](https://togithub.com/golang-jwt/jwt/releases/tag/v5.1.0) [Compare Source](https://togithub.com/golang-jwt/jwt/compare/v5.0.0...v5.1.0) #### What's Changed - Using jwt's native `ErrInvalidType` instead of `json.UnsupportedTypeError` by [@​oxisto](https://togithub.com/oxisto) in [golang-jwt/jwt#316 - Fix typos in comments and test names by [@​alexandear](https://togithub.com/alexandear) in [golang-jwt/jwt#317 - Format: add whitespaces, remove empty lines by [@​alexandear](https://togithub.com/alexandear) in [golang-jwt/jwt#319 - Refactor example: use io.ReadAll instead of io.Copy by [@​alexandear](https://togithub.com/alexandear) in [golang-jwt/jwt#320 - Refactor code by using switch instead of if-else by [@​alexandear](https://togithub.com/alexandear) in [golang-jwt/jwt#318 - A quick way to validate token string by [@​dcalsky](https://togithub.com/dcalsky) in [golang-jwt/jwt#302 - Refactor: remove unnecessary \[]byte conversion to string by [@​alexandear](https://togithub.com/alexandear) in [golang-jwt/jwt#330 - Refactor: compare strings with strings.EqualFold by [@​alexandear](https://togithub.com/alexandear) in [golang-jwt/jwt#329 - Avoid use of json.NewDecoder by [@​craigpastro](https://togithub.com/craigpastro) in [golang-jwt/jwt#313 - Update ParseUnverified godoc by [@​duhaesbaert](https://togithub.com/duhaesbaert) in [golang-jwt/jwt#341 - Update ci workflows (add go1.21) by [@​mfridman](https://togithub.com/mfridman) in [golang-jwt/jwt#345 - Bump actions/checkout from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [golang-jwt/jwt#346 - Key rotation with VerificationKeySet by [@​mfridman](https://togithub.com/mfridman) in [golang-jwt/jwt#344 - Add explicit ClaimsValidator implementation check for custom claims by [@​epelc](https://togithub.com/epelc) in [golang-jwt/jwt#343 - feat: allow making exp claim required by [@​tareksha](https://togithub.com/tareksha) in [golang-jwt/jwt#351 - Add error handling to examples by [@​craigpastro](https://togithub.com/craigpastro) in [golang-jwt/jwt#312 #### New Contributors - [@​alexandear](https://togithub.com/alexandear) made their first contribution in [golang-jwt/jwt#317 - [@​dcalsky](https://togithub.com/dcalsky) made their first contribution in [golang-jwt/jwt#302 - [@​craigpastro](https://togithub.com/craigpastro) made their first contribution in [golang-jwt/jwt#313 - [@​duhaesbaert](https://togithub.com/duhaesbaert) made their first contribution in [golang-jwt/jwt#341 - [@​epelc](https://togithub.com/epelc) made their first contribution in [golang-jwt/jwt#343 - [@​tareksha](https://togithub.com/tareksha) made their first contribution in [golang-jwt/jwt#351 **Full Changelog**: golang-jwt/jwt@v5.0.0...v5.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 6am on Monday" in timezone Europe/Paris, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/cozy/cozy-stack). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1hc3RlciJ9-->
github-merge-queue bot
pushed a commit
to infratographer/x
that referenced
this pull request
Apr 2, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/golang-jwt/jwt/v5](https://togithub.com/golang-jwt/jwt) | `v5.0.0` -> `v5.2.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>golang-jwt/jwt (github.com/golang-jwt/jwt/v5)</summary> ### [`v5.2.1`](https://togithub.com/golang-jwt/jwt/releases/tag/v5.2.1) [Compare Source](https://togithub.com/golang-jwt/jwt/compare/v5.2.0...v5.2.1) #### What's Changed - chore: remove unnecessary conversions from tests by [@​estensen](https://togithub.com/estensen) in [golang-jwt/jwt#370 - Trivial: Typo fix for ECDSA error message by [@​tjs-cinemo](https://togithub.com/tjs-cinemo) in [golang-jwt/jwt#373 - Fix incorrect error return by [@​ss49919201](https://togithub.com/ss49919201) in [golang-jwt/jwt#371 #### New Contributors - [@​tjs-cinemo](https://togithub.com/tjs-cinemo) made their first contribution in [golang-jwt/jwt#373 - [@​ss49919201](https://togithub.com/ss49919201) made their first contribution in [golang-jwt/jwt#371 **Full Changelog**: golang-jwt/jwt@v5.2.0...v5.2.1 ### [`v5.2.0`](https://togithub.com/golang-jwt/jwt/releases/tag/v5.2.0) [Compare Source](https://togithub.com/golang-jwt/jwt/compare/v5.1.0...v5.2.0) #### What's Changed - Exported `NewValidator` by [@​oxisto](https://togithub.com/oxisto) in [golang-jwt/jwt#349 - Improve ErrInvalidKeyType error messages by [@​Laurin-Notemann](https://togithub.com/Laurin-Notemann) in [golang-jwt/jwt#361 - Update MIGRATION_GUIDE.md by [@​jbarham](https://togithub.com/jbarham) in [golang-jwt/jwt#363 #### New Contributors - [@​Laurin-Notemann](https://togithub.com/Laurin-Notemann) made their first contribution in [golang-jwt/jwt#361 - [@​jbarham](https://togithub.com/jbarham) made their first contribution in [golang-jwt/jwt#363 **Full Changelog**: golang-jwt/jwt@v5.1.0...v5.2.0 ### [`v5.1.0`](https://togithub.com/golang-jwt/jwt/releases/tag/v5.1.0) [Compare Source](https://togithub.com/golang-jwt/jwt/compare/v5.0.0...v5.1.0) #### What's Changed - Using jwt's native `ErrInvalidType` instead of `json.UnsupportedTypeError` by [@​oxisto](https://togithub.com/oxisto) in [golang-jwt/jwt#316 - Fix typos in comments and test names by [@​alexandear](https://togithub.com/alexandear) in [golang-jwt/jwt#317 - Format: add whitespaces, remove empty lines by [@​alexandear](https://togithub.com/alexandear) in [golang-jwt/jwt#319 - Refactor example: use io.ReadAll instead of io.Copy by [@​alexandear](https://togithub.com/alexandear) in [golang-jwt/jwt#320 - Refactor code by using switch instead of if-else by [@​alexandear](https://togithub.com/alexandear) in [golang-jwt/jwt#318 - A quick way to validate token string by [@​dcalsky](https://togithub.com/dcalsky) in [golang-jwt/jwt#302 - Refactor: remove unnecessary \[]byte conversion to string by [@​alexandear](https://togithub.com/alexandear) in [golang-jwt/jwt#330 - Refactor: compare strings with strings.EqualFold by [@​alexandear](https://togithub.com/alexandear) in [golang-jwt/jwt#329 - Avoid use of json.NewDecoder by [@​craigpastro](https://togithub.com/craigpastro) in [golang-jwt/jwt#313 - Update ParseUnverified godoc by [@​duhaesbaert](https://togithub.com/duhaesbaert) in [golang-jwt/jwt#341 - Update ci workflows (add go1.21) by [@​mfridman](https://togithub.com/mfridman) in [golang-jwt/jwt#345 - Bump actions/checkout from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [golang-jwt/jwt#346 - Key rotation with VerificationKeySet by [@​mfridman](https://togithub.com/mfridman) in [golang-jwt/jwt#344 - Add explicit ClaimsValidator implementation check for custom claims by [@​epelc](https://togithub.com/epelc) in [golang-jwt/jwt#343 - feat: allow making exp claim required by [@​tareksha](https://togithub.com/tareksha) in [golang-jwt/jwt#351 - Add error handling to examples by [@​craigpastro](https://togithub.com/craigpastro) in [golang-jwt/jwt#312 #### New Contributors - [@​alexandear](https://togithub.com/alexandear) made their first contribution in [golang-jwt/jwt#317 - [@​dcalsky](https://togithub.com/dcalsky) made their first contribution in [golang-jwt/jwt#302 - [@​craigpastro](https://togithub.com/craigpastro) made their first contribution in [golang-jwt/jwt#313 - [@​duhaesbaert](https://togithub.com/duhaesbaert) made their first contribution in [golang-jwt/jwt#341 - [@​epelc](https://togithub.com/epelc) made their first contribution in [golang-jwt/jwt#343 - [@​tareksha](https://togithub.com/tareksha) made their first contribution in [golang-jwt/jwt#351 **Full Changelog**: golang-jwt/jwt@v5.0.0...v5.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/infratographer/x). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when parsing claim values, we used
json.UnsupportedTypeErrorto denote if a claim string value is not of the correct type. However, this could lead to panics if a nil value is present and theErrorfunction of thejson.UnsupportedTypeErroris called, which does not check for nil types.Instead, we just now use
ErrInvalidTypesimilar to the map claims.Fixes #315