Mysql - Fix crash with ansi_quotes sql_mode enabled (#476)

* Fix crash with ansi_quotes * Run lint
golang-migrate · Nov 18, 2020 · 1593164 · 1593164
1 parent fedbe42
commit 1593164
Show file tree

Hide file tree

Showing 2 changed files with 50 additions and 1 deletion.
diff --git a/database/mysql/mysql.go b/database/mysql/mysql.go
@@ -449,7 +449,7 @@ func (m *Mysql) ensureVersionTable() (err error) {
 
 	// check if migration table exists
 	var result string
-	query := `SHOW TABLES LIKE "` + m.config.MigrationsTable + `"`
+	query := `SHOW TABLES LIKE '` + m.config.MigrationsTable + `'`
 	if err := m.conn.QueryRowContext(context.Background(), query).Scan(&result); err != nil {
 		if err != sql.ErrNoRows {
 			return &database.Error{OrigErr: err, Query: []byte(query)}

diff --git a/database/mysql/mysql_test.go b/database/mysql/mysql_test.go
@@ -39,13 +39,24 @@ var (
 		Env:          map[string]string{"MYSQL_ROOT_PASSWORD": "root", "MYSQL_DATABASE": "public"},
 		PortRequired: true, ReadyFunc: isReady,
 	}
+	optsAnsiQuotes = dktest.Options{
+		Env:          map[string]string{"MYSQL_ROOT_PASSWORD": "root", "MYSQL_DATABASE": "public"},
+		PortRequired: true, ReadyFunc: isReady,
+		Cmd: []string{"--sql-mode=ANSI_QUOTES"},
+	}
 	// Supported versions: https://www.mysql.com/support/supportedplatforms/database.html
 	specs = []dktesting.ContainerSpec{
 		{ImageName: "mysql:5.5", Options: opts},
 		{ImageName: "mysql:5.6", Options: opts},
 		{ImageName: "mysql:5.7", Options: opts},
 		{ImageName: "mysql:8", Options: opts},
 	}
+	specsAnsiQuotes = []dktesting.ContainerSpec{
+		{ImageName: "mysql:5.5", Options: optsAnsiQuotes},
+		{ImageName: "mysql:5.6", Options: optsAnsiQuotes},
+		{ImageName: "mysql:5.7", Options: optsAnsiQuotes},
+		{ImageName: "mysql:8", Options: optsAnsiQuotes},
+	}
 )
 
 func isReady(ctx context.Context, c dktest.ContainerInfo) bool {
@@ -147,6 +158,44 @@ func TestMigrate(t *testing.T) {
 	})
 }
 
+func TestMigrateAnsiQuotes(t *testing.T) {
+	// mysql.SetLogger(mysql.Logger(log.New(ioutil.Discard, "", log.Ltime)))
+
+	dktesting.ParallelTest(t, specsAnsiQuotes, func(t *testing.T, c dktest.ContainerInfo) {
+		ip, port, err := c.Port(defaultPort)
+		if err != nil {
+			t.Fatal(err)
+		}
+
+		addr := fmt.Sprintf("mysql://root:root@tcp(%v:%v)/public", ip, port)
+		p := &Mysql{}
+		d, err := p.Open(addr)
+		if err != nil {
+			t.Fatal(err)
+		}
+		defer func() {
+			if err := d.Close(); err != nil {
+				t.Error(err)
+			}
+		}()
+
+		m, err := migrate.NewWithDatabaseInstance("file://./examples/migrations", "public", d)
+		if err != nil {
+			t.Fatal(err)
+		}
+		dt.TestMigrate(t, m)
+
+		// check ensureVersionTable
+		if err := d.(*Mysql).ensureVersionTable(); err != nil {
+			t.Fatal(err)
+		}
+		// check again
+		if err := d.(*Mysql).ensureVersionTable(); err != nil {
+			t.Fatal(err)
+		}
+	})
+}
+
 func TestLockWorks(t *testing.T) {
 	dktesting.ParallelTest(t, specs, func(t *testing.T, c dktest.ContainerInfo) {
 		ip, port, err := c.Port(defaultPort)