Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mysql - Fix crash with ansi_quotes sql_mode enabled #476

Merged
merged 2 commits into from
Nov 18, 2020
Merged

Mysql - Fix crash with ansi_quotes sql_mode enabled #476

merged 2 commits into from
Nov 18, 2020

Conversation

MacTynow
Copy link
Contributor

Closes #475

@coveralls
Copy link

coveralls commented Nov 18, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 930

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.205%
Totals Coverage Status
Change from base Build 919: 0.0%
Covered Lines: 3044
Relevant Lines: 5514
💛 - Coveralls

dhui
dhui approved these changes Nov 18, 2020
View reviewed changes
Copy link
Member

@dhui dhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reporting and fixing the issue and for adding tests!

@dhui dhui merged commit 1593164 into golang-migrate:master Nov 18, 2020
@renovate renovate bot mentioned this pull request May 22, 2021
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhui dhui dhui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MySQL - migrate fails if ANSI or ANSI_QUOTES sql mode is set
3 participants
@MacTynow @coveralls @dhui