Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dep #1

Closed
dhui opened this issue Jan 19, 2018 · 4 comments
Closed

Use dep #1

dhui opened this issue Jan 19, 2018 · 4 comments
Labels
enhancement New feature or request

Comments

@dhui
Copy link
Member

dhui commented Jan 19, 2018

Hold off on using dep until it supports build tags. We don't want to pull in unnecessary dependencies. e.g. if you're only using migrate for postgres, there's no reason why you should have a dependency on cassandra driver

golang/dep#291
@dhui dhui mentioned this issue Jan 20, 2018
Open
@Its-Alex
Copy link
Contributor

Its-Alex commented May 9, 2018

But for now all dependencies is pulled no ? So with or without dep is the same for dependencies no ?

@dhui
Copy link
Member Author

dhui commented May 9, 2018 •
edited
Loading

Currently, there's a whitelist of db dependencies specified in the Makefile (see the build-cli target and the DATABASE variable)

That being said, maybe it's not so bad to include all db dependencies in the binary. The binary shouldn't get that much larger.

@Its-Alex
Copy link
Contributor

Its-Alex commented May 9, 2018

The executable weights less than 10 mb with all dependencies, moreover when using make deps all dependencies are pulled.

People who wants to build with only one dependency can always do it, so there are no real change to include dep now.

@dhui dhui added the enhancement New feature or request label May 30, 2018
@dhui
Copy link
Member Author

dhui commented May 31, 2018

migrate now uses dep as of commit 3d7b06e and build https://travis-ci.org/golang-migrate/migrate/jobs/386409073

@dhui dhui closed this as completed May 31, 2018
jjfeiler added a commit to jjfeiler/migrate that referenced this issue Jul 10, 2019
@jjfeiler
Merge pull request golang-migrate#1 in OKE/migrate from jjfeiler/orac…
be9f678 
…le-support to master

* commit '7fb76b76ab0bdaea873e34f4d98bbe14515dc30d':
  clean up lint errors
  re-enable other dbs in makefile
  initial commit of working oracle db support
@agnivade agnivade mentioned this issue Feb 26, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dhui @Its-Alex