Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add packr support #171

Closed
wants to merge 1 commit into from
Closed

add packr support #171

wants to merge 1 commit into from

Conversation

nkonev
Copy link

@nkonev nkonev commented Feb 10, 2019

Along with go-bindata it' s will be cool to add packr.

@dhui
Copy link
Member

dhui commented Feb 10, 2019

Thanks for your efforts, but the current plan is to add support for the http.FileSystem interface. Once that's done, support for packr sources should be trivial.

For more info, see this issue and these PRs: original, follow up.

If you'd like support for packr to be merged in sooner, feel free to contribute to either of those PRs and open a subsequent PR for packr support.

@dhui dhui closed this Feb 10, 2019
@coveralls
Copy link

coveralls commented Feb 10, 2019

Pull Request Test Coverage Report for Build 301

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 59.188%

Totals Coverage Status
Change from base Build 298: 0.0%
Covered Lines: 773
Relevant Lines: 1306

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants