Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build-cli: Also build GOOS=windows GOARCH=386, fixes #339 #343

Merged
merged 2 commits into from
Feb 17, 2020
Merged

build-cli: Also build GOOS=windows GOARCH=386, fixes #339 #343

merged 2 commits into from
Feb 17, 2020

Conversation

martinlindhe
Copy link
Contributor

No description provided.

@martinlindhe martinlindhe mentioned this pull request Feb 16, 2020
Closed
@coveralls
Copy link

coveralls commented Feb 17, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 686

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 52.382%
Totals Coverage Status
Change from base Build 685: 0.0%
Covered Lines: 2496
Relevant Lines: 4765
💛 - Coveralls

@dhui dhui merged commit 51f9aab into golang-migrate:master Feb 17, 2020
@martinlindhe
Copy link
Contributor Author

It seems we missed something.

Would adding the new 386 exe to this list be enough for it to be published?

https://github.com/golang-migrate/migrate/blob/master/.travis.yml#L73

@dhui
Copy link
Member

dhui commented Feb 17, 2020

Properly released in v4.9.1

@Gonzih Gonzih mentioned this pull request Feb 18, 2020
Merged
@renovate renovate bot mentioned this pull request May 22, 2021
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhui dhui dhui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martinlindhe @coveralls @dhui