Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt before dropping the entire database #360

Merged
merged 2 commits into from
Mar 18, 2020

Conversation

niksoper
Copy link
Contributor

This follows the same pattern as down to require a prompt before dropping the entire database via drop.

@coveralls
Copy link

coveralls commented Mar 17, 2020

Pull Request Test Coverage Report for Build 727

  • 0 of 10 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 53.08%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/cli/main.go 0 10 0.0%
Totals Coverage Status
Change from base Build 723: -0.1%
Covered Lines: 2559
Relevant Lines: 4821

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 726

  • 0 of 9 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 53.091%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/cli/main.go 0 9 0.0%
Totals Coverage Status
Change from base Build 723: -0.1%
Covered Lines: 2559
Relevant Lines: 4820

💛 - Coveralls

Copy link
Member

@dhui dhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
Just a few minor issues.

internal/cli/main.go Outdated Show resolved Hide resolved
internal/cli/main.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants