clickhouse: honor DefaultMigrationsTableEngine when created WithInstance()
#617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1220557373
💛 - Coveralls |
dhui
requested changes
Sep 7, 2021
| @@ -127,6 +127,10 @@ func (ch *ClickHouse) init() error { | |||
| ch.config.MultiStatementMaxSize = DefaultMultiStatementMaxSize | |||
| } | |||
|
|
|||
| if len(ch.config.MigrationsTableEngine) == 0 { | |||
There was a problem hiding this comment.
Is the odd white spacing a github issue?
There was a problem hiding this comment.
I would think so, gofmt -s -w database/clickhouse/clickhouse.go yield no diff.
| @@ -106,6 +106,33 @@ func testSimple(t *testing.T, engine string) { | |||
| }) | |||
| } | |||
|
|
|||
| func testSimpleWithInstance(t *testing.T) { | |||
There was a problem hiding this comment.
Add a comment that this is intended to test setting default config values with instances (or rename the test accordingly)
There was a problem hiding this comment.
renamed to testSimpleWithInstanceDefaultConfigValues.
…nce()
Before this patch, clickhouse.WithInstance() would not select
DefaultMigrationsTableEngine when no MigrationsTableEngine was provided
through the clickhouse.Config{} argument. This behaviour forces the
caller to always provide explicitely the config's MigrationsTableEngine.
This patch make it so DefaultMigrationsTableEngine is used when
MigrationsTableEngine is not provided through clickhouse.Config{}.
Signed-off-by: Alexandre Perrin <alex@kaworu.ch>
dhui
approved these changes
Sep 11, 2021
kaworu
deleted the
pr/kaworu/database/clickhouse/honor-DefaultMigrationsTableEngine
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch,
clickhouse.WithInstance()would not selectDefaultMigrationsTableEnginewhen noMigrationsTableEnginewas provided through theclickhouse.Configargument. This behaviour forces the caller to always provide explicitely the config'sMigrationsTableEngine.This patch make it so
DefaultMigrationsTableEngineis used whenMigrationsTableEngineis not provided throughclickhouse.Config.