Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clickhouse: honor DefaultMigrationsTableEngine when created WithInstance() #617

Merged
merged 1 commit into from
Sep 11, 2021
Merged

clickhouse: honor DefaultMigrationsTableEngine when created WithInstance() #617

merged 1 commit into from
Sep 11, 2021

Commits on Sep 10, 2021

  1. clickhouse: honor DefaultMigrationsTableEngine when created WithInsta…

    …nce()
    
    Before this patch, clickhouse.WithInstance() would not select
    DefaultMigrationsTableEngine when no MigrationsTableEngine was provided
    through the clickhouse.Config{} argument. This behaviour forces the
    caller to always provide explicitely the config's MigrationsTableEngine.
    
    This patch make it so DefaultMigrationsTableEngine is used when
    MigrationsTableEngine is not provided through clickhouse.Config{}.
    
    Signed-off-by: Alexandre Perrin <alex@kaworu.ch>
    kaworu committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    9db2d01 View commit details
    Browse the repository at this point in the history