Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Changelog #131

Merged
merged 18 commits into from
Apr 30, 2021
Merged

Add Changelog #131

merged 18 commits into from
Apr 30, 2021

Conversation

pellared
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Apr 30, 2021 •
edited
Loading

Codecov Report

Merging #131 (43ebe46) into main (d3d21cc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #131   +/-   ##
=======================================
  Coverage   50.00%   50.00%           
=======================================
  Files           1        1           
  Lines           2        2           
=======================================
  Hits            1        1           
  Misses          1        1
Flag Coverage Δ
Linux 50.00% <ø> (ø)
Windows 50.00% <ø> (ø)
macOS 50.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3d21cc...43ebe46. Read the comment docs.

@pellared pellared marked this pull request as ready for review April 30, 2021 08:01
@pellared pellared requested a review from agabrys April 30, 2021 08:01
agabrys
agabrys requested changes Apr 30, 2021
View reviewed changes
Copy link
Contributor

@agabrys agabrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The the word is missing in a few places. I think it would be also good to point to the code in a specific revision. I also added some other suggestions.

You don't have to agree, but you gave me the Approve powers, so yeah 😃😝

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
pellared and others added 5 commits April 30, 2021 13:15
@pellared @agabrys
Update CHANGELOG.md
df0ec95 
Co-authored-by: Adam Gabryś <adam.gabrys@live.com>
@pellared @agabrys
Update CHANGELOG.md
3624d51 
Co-authored-by: Adam Gabryś <adam.gabrys@live.com>
@pellared @agabrys
Update CHANGELOG.md
03d6b68 
Co-authored-by: Adam Gabryś <adam.gabrys@live.com>
@pellared @agabrys
Apply suggestions from code review
6bd0cc2 
Co-authored-by: Adam Gabryś <adam.gabrys@live.com>
@pellared
Update CHANGELOG.md
bd9535e
@pellared pellared requested a review from agabrys April 30, 2021 11:23
@pellared pellared merged commit 9d8f027 into main Apr 30, 2021
@pellared pellared deleted the add-changelog branch April 30, 2021 11:31
@pellared pellared mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agabrys agabrys agabrys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pellared @agabrys