Skip to content

Commit

Permalink
internal/task: opt x/vuln in for updates only
Browse files Browse the repository at this point in the history
x/vuln opted out of automatic tagging, but there's no reason for it not
to receive automatic updates. Also see a motivating data point captured
in https://go.dev/issue/56530#issuecomment-1342988547.

Now that there's a more fine-grained method of controlling whether to
tag a repo, move the decision there and stop ignoring the entire vuln
repo.

For golang/go#59686.
For golang/go#56530.

Change-Id: I32815b3d52d7bd2e601b4eae0290008b33eefbec
Reviewed-on: https://go-review.googlesource.com/c/build/+/525655
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
  • Loading branch information
dmitshur authored and gopherbot committed Nov 22, 2023
1 parent 3a561a6 commit d83deb5
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
1 change: 0 additions & 1 deletion cmd/relui/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,6 @@ func main() {
for p, r := range repos.ByGerritProject {
ignoreProjects[p] = !r.ShowOnDashboard()
}
ignoreProjects["vuln"] = true // x/vuln only has manual tagging for now. See issue 59686.
tagTasks := &task.TagXReposTasks{
IgnoreProjects: ignoreProjects,
Gerrit: gerritClient,
Expand Down
4 changes: 4 additions & 0 deletions internal/task/tagx.go
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,10 @@ type TagRepo struct {
// UpdateOnlyAndNotTag reports whether repo
// r should be updated only, and not tagged.
func (r TagRepo) UpdateOnlyAndNotTag() bool {
if r.Name == "vuln" {
return true // x/vuln only has manual tagging for now. See go.dev/issue/59686.
}

// Consider a repo without an existing tag as one
// that hasn't yet opted in for automatic tagging.
return r.StartVersion == ""
Expand Down

0 comments on commit d83deb5

Please sign in to comment.