Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/vuln: release version v0.1.0 #59686

Closed
5 of 6 tasks
julieqiu opened this issue Apr 18, 2023 · 4 comments
Closed
5 of 6 tasks

x/vuln: release version v0.1.0 #59686

julieqiu opened this issue Apr 18, 2023 · 4 comments
Labels
NeedsFix The path to resolution is known, but the work has not been done. vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Milestone
vuln/v0.1.0

Comments

@julieqiu
Copy link
Member

julieqiu commented Apr 18, 2023 •
edited by dmitshur

This issue tracks progress toward releasing x/vuln@v0.1.0.
@julieqiu julieqiu added the vulncheck or vulndb Issues for the x/vuln or x/vulndb repo label Apr 18, 2023
@gopherbot gopherbot modified the milestones: Unreleased, vuln/unplanned Apr 18, 2023
@julieqiu julieqiu modified the milestones: vuln/unplanned, vuln/v0.1.0 Apr 18, 2023
@gopherbot
Copy link

Change https://go.dev/cl/485978 mentions this issue: cmd/relui: ignore x/vuln when tagging x/ repos

@gopherbot
Copy link

Change https://go.dev/cl/485979 mentions this issue: internal/task: apply TagXReposTasks.IgnoreProjects only to automatic tagging

@gopherbot
Copy link

Change https://go.dev/cl/487076 mentions this issue: internal/task: add tagx multi-repo ignore set

@prattmic prattmic added the NeedsFix The path to resolution is known, but the work has not been done. label Apr 21, 2023
gopherbot pushed a commit to golang/build that referenced this issue Apr 24, 2023
@prattmic
cmd/relui: ignore x/vuln when tagging x/ repos
16fdd0f 
x/vuln will soon start tagging releases, but does not want automatic
tagging yet, only manual tags. However, as soon as the first tag is
created then the repo will become eligible for automatic tagging.

Add an explicit ignore for x/vuln to the task to avoid eligibility.

This isn't ideal because the single tag task also uses the ignore list,
so tags must be created manually, but this unblocks the process.

For golang/go#59686.

Change-Id: Iac190e1da5edd328aacdb001b7ef6acfefafdb98
Reviewed-on: https://go-review.googlesource.com/c/build/+/485978
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Run-TryBot: Michael Pratt <mpratt@google.com>
@gopherbot
Copy link

Change https://go.dev/cl/525655 mentions this issue: internal/task: opt x/vuln in for updates only

gopherbot pushed a commit to golang/build that referenced this issue Nov 22, 2023
@dmitshur @gopherbot
internal/task: opt x/vuln in for updates only
d83deb5 
x/vuln opted out of automatic tagging, but there's no reason for it not
to receive automatic updates. Also see a motivating data point captured
in https://go.dev/issue/56530#issuecomment-1342988547.

Now that there's a more fine-grained method of controlling whether to
tag a repo, move the decision there and stop ignoring the entire vuln
repo.

For golang/go#59686.
For golang/go#56530.

Change-Id: I32815b3d52d7bd2e601b4eae0290008b33eefbec
Reviewed-on: https://go-review.googlesource.com/c/build/+/525655
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsFix The path to resolution is known, but the work has not been done. vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Projects
None yet
Milestone
vuln/v0.1.0
Development

No branches or pull requests
3 participants
@prattmic @julieqiu @gopherbot