This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
Fix ignored per-project prune options (#1561) #1562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use prune options defined per-project when generating gps.RootPruneOptions * Add test cases checking if this behavior is correct
speijnik
force-pushed
the
per-project-prune-fixes
branch
from
b13d6aa
to
beab249
Compare
|
Updated CHANGELOG.md |
sdboyer
suggested changes
Jan 24, 2018
| GoTests: true, | ||
| Projects: []rawPruneProjectOptions{ | ||
| { | ||
| Name: "github.com/golang/dep/gps", |
There was a problem hiding this comment.
Not actually a legal name, here - it's expected to be a project root (github.com/golang/dep). Given the inherent ambiguity of this, even if the test does what we want in the short term, it's better to never give the wrong impression.
|
actually just going to merge as-is, then i'll fix. thanks. |
|
Perfect, thanks for merging the PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
Per-project prune option handling is broken in v0.4.0. This PR fixes the handling and add corresponding
tests.
Which issue(s) does this PR fix?
Fixes #1561