Skip to content

Commit

Permalink
spec: fix conversion rules (match implementation)
Browse files Browse the repository at this point in the history
As written, the conversion P(x), where P and the type
of x are type parameters with identical underlying types
(i.e., identical constraints), is valid. However, unless
the type of x and P are identical (which is covered with
the assignability rule), such a conversion is not valid
in general (consider the case where both type parameters
are different type parameters with constraint "any").

This change adjusts the rules to prohibit type parameters
in this case. The same reasoning applies and the analogue
change is made for pointer types.

The type checker already implements these updated rules.

Change-Id: Id90187900cb2820f6a0a0cf582cf26cdf8addbce
Reviewed-on: https://go-review.googlesource.com/c/go/+/371074
Trust: Robert Griesemer <gri@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
  • Loading branch information
griesemer committed Dec 13, 2021
1 parent acc65b4 commit 083ef54
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions doc/go_spec.html
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<!--{
"Title": "The Go Programming Language Specification - Go 1.18 Draft (incomplete)",
"Subtitle": "Version of Nov 29, 2021",
"Subtitle": "Version of Dec 13, 2021",
"Path": "/ref/spec"
}-->

Expand Down Expand Up @@ -4782,14 +4782,16 @@ <h3 id="Conversions">Conversions</h3>
</li>
<li>
ignoring struct tags (see below),
<code>x</code>'s type and <code>T</code> have <a href="#Type_identity">identical</a>
<a href="#Types">underlying types</a>.
<code>x</code>'s type and <code>T</code> are not
<a href="#Type_parameters">type parameters</a> but have
<a href="#Type_identity">identical</a> <a href="#Types">underlying types</a>.
</li>
<li>
ignoring struct tags (see below),
<code>x</code>'s type and <code>T</code> are pointer types
that are not <a href="#Types">named types</a>,
and their pointer base types have identical underlying types.
and their pointer base types are not type parameters but
have identical underlying types.
</li>
<li>
<code>x</code>'s type and <code>T</code> are both integer or floating
Expand Down

0 comments on commit 083ef54

Please sign in to comment.