-
Notifications
You must be signed in to change notification settings - Fork 17.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
net/http/httptest: mimic the normal HTTP server's ResponseWriter more…
… closely Also adds tests, which didn't exist before. Fixes #4188 R=golang-dev, rsc CC=golang-dev https://golang.org/cl/6613062
- Loading branch information
Showing
2 changed files
with
109 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,90 @@ | ||
// Copyright 2012 The Go Authors. All rights reserved. | ||
// Use of this source code is governed by a BSD-style | ||
// license that can be found in the LICENSE file. | ||
|
||
package httptest | ||
|
||
import ( | ||
"fmt" | ||
"net/http" | ||
"testing" | ||
) | ||
|
||
func TestRecorder(t *testing.T) { | ||
type checkFunc func(*ResponseRecorder) error | ||
check := func(fns ...checkFunc) []checkFunc { return fns } | ||
|
||
hasStatus := func(wantCode int) checkFunc { | ||
return func(rec *ResponseRecorder) error { | ||
if rec.Code != wantCode { | ||
return fmt.Errorf("Status = %d; want %d", rec.Code, wantCode) | ||
} | ||
return nil | ||
} | ||
} | ||
hasContents := func(want string) checkFunc { | ||
return func(rec *ResponseRecorder) error { | ||
if rec.Body.String() != want { | ||
return fmt.Errorf("wrote = %q; want %q", rec.Body.String(), want) | ||
} | ||
return nil | ||
} | ||
} | ||
hasFlush := func(want bool) checkFunc { | ||
return func(rec *ResponseRecorder) error { | ||
if rec.Flushed != want { | ||
return fmt.Errorf("Flushed = %v; want %v", rec.Flushed, want) | ||
} | ||
return nil | ||
} | ||
} | ||
|
||
tests := []struct { | ||
name string | ||
h func(w http.ResponseWriter, r *http.Request) | ||
checks []checkFunc | ||
}{ | ||
{ | ||
"200 default", | ||
func(w http.ResponseWriter, r *http.Request) {}, | ||
check(hasStatus(200), hasContents("")), | ||
}, | ||
{ | ||
"first code only", | ||
func(w http.ResponseWriter, r *http.Request) { | ||
w.WriteHeader(201) | ||
w.WriteHeader(202) | ||
w.Write([]byte("hi")) | ||
}, | ||
check(hasStatus(201), hasContents("hi")), | ||
}, | ||
{ | ||
"write sends 200", | ||
func(w http.ResponseWriter, r *http.Request) { | ||
w.Write([]byte("hi first")) | ||
w.WriteHeader(201) | ||
w.WriteHeader(202) | ||
}, | ||
check(hasStatus(200), hasContents("hi first"), hasFlush(false)), | ||
}, | ||
{ | ||
"flush", | ||
func(w http.ResponseWriter, r *http.Request) { | ||
w.(http.Flusher).Flush() // also sends a 200 | ||
w.WriteHeader(201) | ||
}, | ||
check(hasStatus(200), hasFlush(true)), | ||
}, | ||
} | ||
r, _ := http.NewRequest("GET", "http://foo.com/", nil) | ||
for _, tt := range tests { | ||
h := http.HandlerFunc(tt.h) | ||
rec := NewRecorder() | ||
h.ServeHTTP(rec, r) | ||
for _, check := range tt.checks { | ||
if err := check(rec); err != nil { | ||
t.Errorf("%s: %v", tt.name, err) | ||
} | ||
} | ||
} | ||
} |