Skip to content

Commit

Permalink
[release-branch.go1.4] all.bash: skip tests by default
Browse files Browse the repository at this point in the history
The 1.4 tests aren't necessarily supposed to pass.
Disable them by default, to avoid the sort of
unpleasant experience described in #25816.

Change-Id: I763b8e52c8d16f4d9be14ad853df456652e51430
Reviewed-on: https://go-review.googlesource.com/124077
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
  • Loading branch information
josharian authored and bradfitz committed Jul 25, 2018
1 parent 94221a0 commit 182bdbb
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 0 deletions.
5 changes: 5 additions & 0 deletions src/all.bash
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@ if [ ! -f make.bash ]; then
fi
OLDPATH="$PATH"
. ./make.bash "$@" --no-banner
if [ "$GO14TESTS" != "1" ]; then
echo "Build complete; skipping tests."
echo "To force tests, set GO14TESTS=1 and re-run, but expect some failures."
exit
fi
bash run.bash --no-rebuild
PATH="$OLDPATH"
$GOTOOLDIR/dist banner # print build info
5 changes: 5 additions & 0 deletions src/all.bat
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,11 @@ goto end
set OLDPATH=%PATH%
call make.bat --no-banner --no-local
if %GOBUILDFAIL%==1 goto end
if x%GO14TESTS%==x1 goto runtests
echo Build complete; skipping tests.
echo To force tests, set GO14TESTS=1 and re-run, but expect some failures.
goto end
:runtests
call run.bat --no-rebuild --no-local
if %GOBUILDFAIL%==1 goto end
:: we must restore %PATH% before running "dist banner" so that the latter
Expand Down
5 changes: 5 additions & 0 deletions src/all.rc
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@ if(! test -f make.rc){
}

. ./make.rc --no-banner
if(~ $GO14TESTS ''){
echo 'Build complete; skipping tests.'
echo 'To force tests, set GO14TESTS = 1 and re-run, but expect some failures.'
exit
}
bind -b $GOROOT/bin /bin
./run.rc --no-rebuild
$GOTOOLDIR/dist banner # print build info

0 comments on commit 182bdbb

Please sign in to comment.