Skip to content

Commit

Permalink
cmd/link/internal/ld: ensure mach-o debug symbols are visible to App …
Browse files Browse the repository at this point in the history
…Store

Passing test that shows Apple's symbols utility can now read
DWARF data in go.o, after the fix in CL174538

Updates #31022 #22716 #31459

Change-Id: I56c3517ad6d0a9f39537182f63cef56bb198aa83
Reviewed-on: https://go-review.googlesource.com/c/go/+/170451
Reviewed-by: Than McIntosh <thanm@google.com>
  • Loading branch information
tmm1 authored and thanm committed May 30, 2019
1 parent a0c96a9 commit 2ae793e
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/cmd/link/dwarf_test.go
Expand Up @@ -98,6 +98,8 @@ func testDWARF(t *testing.T, buildmode string, expectDWARF bool, env ...string)
if bytes.HasPrefix(out, []byte("Unable to find file")) {
// This failure will cause the App Store to reject our binaries.
t.Fatalf("symbols %v: failed to parse file", filepath.Base(exe))
} else if bytes.Contains(out, []byte(", Empty]")) {
t.Fatalf("symbols %v: parsed as empty", filepath.Base(exe))
}
}
}
Expand Down

0 comments on commit 2ae793e

Please sign in to comment.