Skip to content

Commit

Permalink
cmd/go: only try to clean executables for package main
Browse files Browse the repository at this point in the history
Fixes #5665.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/12807044
  • Loading branch information
adg committed Aug 19, 2013
1 parent c974b8b commit 2f6e9a1
Showing 1 changed file with 21 additions and 5 deletions.
26 changes: 21 additions & 5 deletions src/cmd/go/clean.go
Expand Up @@ -137,22 +137,38 @@ func clean(p *Package) {
}

_, elem := filepath.Split(p.Dir)
allRemove := []string{
elem,
elem + ".exe",
elem + ".test",
elem + ".test.exe",
var allRemove []string

// Remove dir-named executable only if this is package main.
if p.Name == "main" {
allRemove = append(allRemove,
elem,
elem+".exe",
)
}

// Remove package test executables.
allRemove = append(allRemove,
elem+".test",
elem+".test.exe",
)

// Remove a potental executable for each .go file in the directory that
// is not part of the directory's package.
for _, dir := range dirs {
name := dir.Name()
if packageFile[name] {
continue
}
if !dir.IsDir() && strings.HasSuffix(name, ".go") {
// TODO(adg,rsc): check that this .go file is actually
// in "package main", and therefore capable of building
// to an executable file.
base := name[:len(name)-len(".go")]
allRemove = append(allRemove, base, base+".exe")
}
}

if cleanN || cleanX {
b.showcmd(p.Dir, "rm -f %s", strings.Join(allRemove, " "))
}
Expand Down

0 comments on commit 2f6e9a1

Please sign in to comment.