-
Notifications
You must be signed in to change notification settings - Fork 17.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
cmd/gc: fix inlining bug for composite literals in if statements.
Fixes #4230. R=golang-dev, rsc CC=golang-dev, remy https://golang.org/cl/6640056
- Loading branch information
1 parent
77e42e2
commit 319131f
Showing
4 changed files
with
94 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
// Copyright 2012 The Go Authors. All rights reserved. | ||
// Use of this source code is governed by a BSD-style | ||
// license that can be found in the LICENSE file. | ||
|
||
package a | ||
|
||
type T struct{ A, B int } | ||
|
||
type A []int | ||
|
||
type M map[int]int | ||
|
||
func F1() int { | ||
if (T{1, 2}) == (T{3, 4}) { | ||
return 1 | ||
} | ||
return 0 | ||
} | ||
|
||
func F2() int { | ||
if (M{1: 2}) == nil { | ||
return 1 | ||
} | ||
return 0 | ||
} | ||
|
||
func F3() int { | ||
if nil == (A{}) { | ||
return 1 | ||
} | ||
return 0 | ||
} | ||
|
||
func F4() int { | ||
if a := (A{}); a == nil { | ||
return 1 | ||
} | ||
return 0 | ||
} | ||
|
||
func F5() int { | ||
for k, v := range (M{1: 2}) { | ||
return v - k | ||
} | ||
return 0 | ||
} | ||
|
||
func F6() int { | ||
switch a := (T{1, 1}); a == (T{1, 2}) { | ||
default: | ||
return 1 | ||
} | ||
return 0 | ||
} | ||
|
||
func F7() int { | ||
for m := (M{}); len(m) < (T{1, 2}).A; m[1] = (A{1})[0] { | ||
return 1 | ||
} | ||
return 0 | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
// Copyright 2012 The Go Authors. All rights reserved. | ||
// Use of this source code is governed by a BSD-style | ||
// license that can be found in the LICENSE file. | ||
|
||
package main | ||
|
||
import "./a" | ||
|
||
func main() { | ||
for _, f := range []func() int{ | ||
a.F1, a.F2, a.F3, a.F4, | ||
a.F5, a.F6, a.F7} { | ||
if f() > 1 { | ||
panic("f() > 1") | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
// rundir | ||
|
||
// Copyright 2012 The Go Authors. All rights reserved. | ||
// Use of this source code is governed by a BSD-style | ||
// license that can be found in the LICENSE file. | ||
|
||
// Issue 4230: inlining bug for composite literal in | ||
// if, for, switch statements. | ||
|
||
package ignored |