Skip to content

Commit

Permalink
cmd/compile/internal-abi: update internal ABI spec for g register
Browse files Browse the repository at this point in the history
We've already implemented dedicating R14 as the G register on amd64,
so remove the TODO saying we might want to hold off on this.

For #40724.

Change-Id: I45b24ced03cac862127b53f5e9a4b4bcf6b1f86c
Reviewed-on: https://go-review.googlesource.com/c/go/+/295790
Trust: Austin Clements <austin@google.com>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Reviewed-by: Than McIntosh <thanm@google.com>
  • Loading branch information
aclements committed Feb 24, 2021
1 parent 478277f commit 3deb528
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions src/cmd/compile/internal-abi.md
Expand Up @@ -402,9 +402,6 @@ Special-purpose registers are as follows:
| R15 | GOT reference temporary | Fixed if dynlink |
| X15 | Zero value | Fixed |

TODO: We may start with the existing TLS-based g and move to R14
later.

*Rationale*: These register meanings are compatible with Go’s
stack-based calling convention except for R14 and X15, which will have
to be restored on transitions from ABI0 code to ABIInternal code.
Expand Down

0 comments on commit 3deb528

Please sign in to comment.